Skip to content

Commit 91f5b33

Browse files
fix(hstore): JRaft Timer Metrics BUG (#2602)
1 parent 53f0e18 commit 91f5b33

File tree

1 file changed

+29
-11
lines changed
  • hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/metrics

1 file changed

+29
-11
lines changed

hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/metrics/JRaftMetrics.java

Lines changed: 29 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -214,18 +214,36 @@ private static void registerTimer(String group, String name, com.codahale.metric
214214

215215
String baseName = PREFIX + "." + name.toLowerCase();
216216

217-
Gauge.builder(baseName + ".count", timer, Timer::getCount)
217+
Gauge.builder(baseName + ".count", timer, t->t.getCount())
218+
.tags(tags).register(registry);
219+
Gauge.builder(baseName + ".min", timer, t -> t.getSnapshot().getMin())
220+
.tags(tags).register(registry);
221+
Gauge.builder(baseName + ".max", timer, t -> t.getSnapshot().getMax())
222+
.tags(tags).register(registry);
223+
Gauge.builder(baseName + ".mean", timer, t -> t.getSnapshot().getMean())
224+
.tags(tags).register(registry);
225+
Gauge.builder(baseName + ".stddev", timer, t -> t.getSnapshot().getStdDev())
226+
.tags(tags).register(registry);
227+
Gauge.builder(baseName + ".p50", timer, t -> t.getSnapshot().getMedian())
228+
.tags(tags).register(registry);
229+
Gauge.builder(baseName + ".p75", timer, t -> t.getSnapshot().get75thPercentile())
230+
.tags(tags).register(registry);
231+
Gauge.builder(baseName + ".p95", timer, t -> t.getSnapshot().get95thPercentile())
232+
.tags(tags).register(registry);
233+
Gauge.builder(baseName + ".p98", timer, t -> t.getSnapshot().get98thPercentile())
234+
.tags(tags).register(registry);
235+
Gauge.builder(baseName + ".p99", timer, t -> t.getSnapshot().get99thPercentile())
236+
.tags(tags).register(registry);
237+
Gauge.builder(baseName + ".p999", timer, t -> t.getSnapshot().get999thPercentile())
238+
.tags(tags).register(registry);
239+
Gauge.builder(baseName + ".m1_rate", timer, t -> t.getOneMinuteRate())
240+
.tags(tags).register(registry);
241+
Gauge.builder(baseName + ".m5_rate", timer, t -> t.getFiveMinuteRate())
242+
.tags(tags).register(registry);
243+
Gauge.builder(baseName + ".m15_rate", timer, t -> t.getFifteenMinuteRate())
244+
.tags(tags).register(registry);
245+
Gauge.builder(baseName + ".mean_rate", timer, t -> t.getMeanRate())
218246
.tags(tags).register(registry);
219-
220-
Gauge.builder(baseName + ".timer", timer, Timer::getCount)
221-
.tags(tags).tag("rate", "1m").register(registry);
222-
Gauge.builder(baseName + ".timer", timer, Timer::getCount)
223-
.tags(tags).tag("rate", "5m").register(registry);
224-
Gauge.builder(baseName + ".timer", timer, Timer::getCount)
225-
.tags(tags).tag("rate", "15m").register(registry);
226-
Gauge.builder(baseName + ".timer", timer, Timer::getCount)
227-
.tags(tags).tag("rate", "mean").register(registry);
228-
229247
}
230248

231249
private static void registerMeter(String group, String name, com.codahale.metrics.Meter meter) {

0 commit comments

Comments
 (0)