add some test case for PageState

imbajin · imbajin · commit 174066ed0a34 · 2021-05-19T23:25:54.000+08:00
diff --git a/hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java b/hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
@@ -6671,6 +6671,8 @@ public void testQueryByPageWithInvalidPage() {
 
     @Test
     public void testQueryByPageWithSpecialBase64Chars() {
+        Assume.assumeTrue("Not support paging",
+                          storeFeatures().supportsQueryByPage());
         final String pageWith3Base64Chars = "AAAAADsyABwAEAqI546LS6WW57unBgA" +
                                             "EAAAAAPB////+8H////4alhxAZS8va6" +
                                             "opcAKpklipAAQAAAAAAAAAAQ==";
@@ -6679,9 +6681,6 @@ public void testQueryByPageWithSpecialBase64Chars() {
                                      "B//// 8H////4alhxAZS8va6opcAKpklipAAQA" +
                                      "AAAAAAAAAQ==";
 
-        Assume.assumeTrue("Not support paging",
-                          storeFeatures().supportsQueryByPage());
-
         HugeGraph graph = graph();
         init100Books();
 
diff --git a/hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/PageStateTest.java b/hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/PageStateTest.java
@@ -23,21 +23,35 @@
 
 import org.junit.Test;
 
+import com.baidu.hugegraph.backend.BackendException;
 import com.baidu.hugegraph.backend.page.PageState;
 import com.baidu.hugegraph.testutil.Assert;
 
 public class PageStateTest {
 
+    private String pageWith3Base64Chars = "AAAAADsyABwAEAqI546LS6WW57unBgA" +
+                                          "EAAAAAPB////+8H////4alhxAZS8va6" +
+                                          "opcAKpklipAAQAAAAAAAAAAQ==";
+
+    private String pageWithSpace = "AAAAADsyABwAEAqI546LS6WW57unBgAEAAAAAP" +
+                                   "B//// 8H////4alhxAZS8va6opcAKpklipAAQA" +
+                                   "AAAAAAAAAQ==";
+
+    @Test
+    public void testOriginalStringPageToBytes() {
+        byte[] validPage = PageState.toBytes(pageWith3Base64Chars);
+        Assert.assertNotNull(validPage);
+
+        Assert.assertThrows(BackendException.class, () -> {
+            PageState.toBytes(pageWithSpace);
+        }, e -> {
+            Assert.assertContains("Invalid page:", e.toString());
+        });
+    }
+
     @Test
     public void testDecodePageWithSpecialBase64Chars() {
         // Assert decode '+' and '/' and '=' and space successfully
-        final String pageWith3Base64Chars = "AAAAADsyABwAEAqI546LS6WW57unBgA" +
-                                            "EAAAAAPB////+8H////4alhxAZS8va6" +
-                                            "opcAKpklipAAQAAAAAAAAAAQ==";
-
-        final String pageWithSpace = "AAAAADsyABwAEAqI546LS6WW57unBgAEAAAAAP" +
-                                     "B//// 8H////4alhxAZS8va6opcAKpklipAAQA" +
-                                     "AAAAAAAAAQ==";
         Assert.assertNotNull(PageState.fromString(pageWith3Base64Chars));
 
         byte[] decodePlus = PageState.fromString(pageWith3Base64Chars)
@@ -46,4 +60,31 @@ public void testDecodePageWithSpecialBase64Chars() {
 
         Assert.assertTrue(Arrays.equals(decodePlus, decodeSpace));
     }
+
+    @Test
+    public void testDecodePageWithInvalidStringPage() {
+        final String invalidPageWithBase64Chars = "dGVzdCBiYXNlNjQ=";
+
+        Assert.assertThrows(BackendException.class, () -> {
+            PageState.fromString(invalidPageWithBase64Chars);
+        }, e -> {
+            Assert.assertContains("Invalid page: '0x", e.toString());
+        });
+
+        final String invalidBase64Chars = "!abc~";
+        Assert.assertThrows(BackendException.class, () -> {
+            PageState.fromString(invalidBase64Chars);
+        }, e -> {
+            Assert.assertContains("Invalid page:", e.toString());
+        });
+    }
+
+    @Test
+    public void testEmptyPageState() {
+        Assert.assertEquals(0, PageState.EMPTY.offset());
+        Assert.assertNull(PageState.EMPTY.toString());
+
+        Assert.assertEquals(PageState.EMPTY,
+                            PageState.fromBytes(PageState.EMPTY_BYTES));
+    }
 }
