HIVE-29448: Remove calls to NOOP JaninoRelMetadataProvider#register method#6307
Merged
zabetak merged 1 commit intoapache:masterfrom Feb 12, 2026
Merged
HIVE-29448: Remove calls to NOOP JaninoRelMetadataProvider#register method#6307zabetak merged 1 commit intoapache:masterfrom
zabetak merged 1 commit intoapache:masterfrom
Conversation
okumin
approved these changes
Feb 9, 2026
Contributor
okumin
left a comment
okumin
left a comment
There was a problem hiding this comment.
+1 if the unused import is removed and CI is green
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java
Show resolved
Hide resolved
|
Member
Author
|
CI is green and the Sonar issues were addressed. I will merge this soon! |
okumin
approved these changes
Feb 11, 2026
Member
Author
|
Many thanks for the review @okumin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Improve code readability and maintenance
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests