Skip to content

Commit 143e9b4

Browse files
authored
HBASE-27758 Inconsistent synchronization in MetricsUserSourceImpl (#5149)
Signed-off-by: Duo Zhang <[email protected]>
1 parent e5620e2 commit 143e9b4

1 file changed

Lines changed: 16 additions & 20 deletions

File tree

‎hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserSourceImpl.java‎

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,14 @@ public MetricsUserSourceImpl(String user, MetricsUserAggregateSourceImpl agg) {
137137

138138
@Override
139139
public void register() {
140-
synchronized (this) {
141-
getHisto = registry.newTimeHistogram(userGetKey);
142-
scanTimeHisto = registry.newTimeHistogram(userScanTimeKey);
143-
putHisto = registry.newTimeHistogram(userPutKey);
144-
deleteHisto = registry.newTimeHistogram(userDeleteKey);
145-
incrementHisto = registry.newTimeHistogram(userIncrementKey);
146-
appendHisto = registry.newTimeHistogram(userAppendKey);
147-
replayHisto = registry.newTimeHistogram(userReplayKey);
148-
blockBytesScannedCount = registry.newCounter(userBlockBytesScannedKey, "", 0);
149-
}
140+
getHisto = registry.newTimeHistogram(userGetKey);
141+
scanTimeHisto = registry.newTimeHistogram(userScanTimeKey);
142+
putHisto = registry.newTimeHistogram(userPutKey);
143+
deleteHisto = registry.newTimeHistogram(userDeleteKey);
144+
incrementHisto = registry.newTimeHistogram(userIncrementKey);
145+
appendHisto = registry.newTimeHistogram(userAppendKey);
146+
replayHisto = registry.newTimeHistogram(userReplayKey);
147+
blockBytesScannedCount = registry.newCounter(userBlockBytesScannedKey, "", 0);
150148
}
151149

152150
@Override
@@ -162,16 +160,14 @@ public void deregister() {
162160
LOG.debug("Removing user Metrics for user: " + user);
163161
}
164162

165-
synchronized (this) {
166-
registry.removeMetric(userGetKey);
167-
registry.removeMetric(userScanTimeKey);
168-
registry.removeMetric(userPutKey);
169-
registry.removeMetric(userDeleteKey);
170-
registry.removeMetric(userIncrementKey);
171-
registry.removeMetric(userAppendKey);
172-
registry.removeMetric(userReplayKey);
173-
registry.removeMetric(userBlockBytesScannedKey);
174-
}
163+
registry.removeMetric(userGetKey);
164+
registry.removeMetric(userScanTimeKey);
165+
registry.removeMetric(userPutKey);
166+
registry.removeMetric(userDeleteKey);
167+
registry.removeMetric(userIncrementKey);
168+
registry.removeMetric(userAppendKey);
169+
registry.removeMetric(userReplayKey);
170+
registry.removeMetric(userBlockBytesScannedKey);
175171
}
176172

177173
@Override

0 commit comments

Comments
 (0)