Repository navigation
Add super.validate() call in OAuth2TokenResponse.validate() method - #8376
Merged
Merged
Conversation
Member
|
You'll need to run Spottless to fix teh code formatting, please run |
justinmclean
reviewed
Sep 1, 2025
| System.exit(1); | ||
| } | ||
| confPath = args[0]; | ||
| } |
Member
There was a problem hiding this comment.
I don't think this change needs to be in this PR.
Contributor
Author
|
Sorry, it seems some unrelated code from another PR was mixed in. I've revised it and pushed the corrected version. |
roryqi
approved these changes
Sep 2, 2025
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Sep 15, 2025
…pache#8376) **What changes were proposed in this pull request?** In common/src/main/java/org/apache/gravitino/dto/responses/OAuth2TokenResponse.java, the validate() method was missing a call to super.validate(). This PR adds the super.validate() call to ensure that the parent class validation logic is executed before the subclass-specific checks. **Why are the changes needed?** Without calling super.validate(), the validation logic defined in BaseResponse is skipped, which could allow invalid responses to pass through. Adding the call ensures both parent and subclass validations are performed correctly. **Does this PR introduce any user-facing change?** No. This change only affects internal validation logic. **Fixes:** apache#8303
bharos
pushed a commit
to bharos/gravitino
that referenced
this pull request
Oct 3, 2025
…pache#8376) **What changes were proposed in this pull request?** In common/src/main/java/org/apache/gravitino/dto/responses/OAuth2TokenResponse.java, the validate() method was missing a call to super.validate(). This PR adds the super.validate() call to ensure that the parent class validation logic is executed before the subclass-specific checks. **Why are the changes needed?** Without calling super.validate(), the validation logic defined in BaseResponse is skipped, which could allow invalid responses to pass through. Adding the call ensures both parent and subclass validations are performed correctly. **Does this PR introduce any user-facing change?** No. This change only affects internal validation logic. **Fixes:** apache#8303
bharos
pushed a commit
to bharos/gravitino
that referenced
this pull request
Oct 7, 2025
…pache#8376) **What changes were proposed in this pull request?** In common/src/main/java/org/apache/gravitino/dto/responses/OAuth2TokenResponse.java, the validate() method was missing a call to super.validate(). This PR adds the super.validate() call to ensure that the parent class validation logic is executed before the subclass-specific checks. **Why are the changes needed?** Without calling super.validate(), the validation logic defined in BaseResponse is skipped, which could allow invalid responses to pass through. Adding the call ensures both parent and subclass validations are performed correctly. **Does this PR introduce any user-facing change?** No. This change only affects internal validation logic. **Fixes:** apache#8303
danhuawang
pushed a commit
to danhuawang/gravitino
that referenced
this pull request
Jun 8, 2026
…pache#8376) **What changes were proposed in this pull request?** In common/src/main/java/org/apache/gravitino/dto/responses/OAuth2TokenResponse.java, the validate() method was missing a call to super.validate(). This PR adds the super.validate() call to ensure that the parent class validation logic is executed before the subclass-specific checks. **Why are the changes needed?** Without calling super.validate(), the validation logic defined in BaseResponse is skipped, which could allow invalid responses to pass through. Adding the call ensures both parent and subclass validations are performed correctly. **Does this PR introduce any user-facing change?** No. This change only affects internal validation logic. **Fixes:** apache#8303
danhuawang
pushed a commit
to danhuawang/gravitino
that referenced
this pull request
Jun 9, 2026
…pache#8376) **What changes were proposed in this pull request?** In common/src/main/java/org/apache/gravitino/dto/responses/OAuth2TokenResponse.java, the validate() method was missing a call to super.validate(). This PR adds the super.validate() call to ensure that the parent class validation logic is executed before the subclass-specific checks. **Why are the changes needed?** Without calling super.validate(), the validation logic defined in BaseResponse is skipped, which could allow invalid responses to pass through. Adding the call ensures both parent and subclass validations are performed correctly. **Does this PR introduce any user-facing change?** No. This change only affects internal validation logic. **Fixes:** apache#8303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In common/src/main/java/org/apache/gravitino/dto/responses/OAuth2TokenResponse.java, the validate() method was missing a call to super.validate(). This PR adds the super.validate() call to ensure that the parent class validation logic is executed before the subclass-specific checks.
Why are the changes needed?
Without calling super.validate(), the validation logic defined in BaseResponse is skipped, which could allow invalid responses to pass through. Adding the call ensures both parent and subclass validations are performed correctly.
Does this PR introduce any user-facing change?
No. This change only affects internal validation logic.
Fixes #8303