Repository navigation
Fix incorrect name/comment assignment in TestModelMetaService tests - #8296
Merged
Merged
Conversation
Contributor
Author
|
It says the test failed, but I can’t see the details of the failure. |
Member
|
I think they just took too long to run and were cancelled |
Contributor
Author
@justinmclean |
Member
|
I can re-run the failed ones for you |
Contributor
Author
Please try running it again. |
Contributor
Author
|
It looks like the test is completed :D |
Contributor
Author
|
Thanks ! |
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Sep 15, 2025
…pache#8296) **What changes were proposed in this pull request?** In `TestModelMetaService.java`, the tests testInsertAndUpdateModelComment and testInsertAndUpdateModelProperties were incorrectly setting the name and comment fields. This PR fixes the assignments so that name and comment are updated correctly according to the test's intent. **Why are the changes needed?** Previously, the tests would either overwrite the name with a comment value or keep the comment unchanged, causing the tests to not properly verify updates. Fixing the assignments ensures that comment updates and property updates are correctly tested. Fixes: apache#8282 **Does this PR introduce any user-facing change?** No. This only fixes test behavior. **How was this patch tested?** - Corrected field assignments in the affected tests. - Verified that `testInsertAndUpdateModelComment` correctly updates the comment without changing the name. - Verified that `testInsertAndUpdateModelProperties` correctly maintains the name and updates properties. - Ran all existing tests to confirm no regressions.
bharos
pushed a commit
to bharos/gravitino
that referenced
this pull request
Oct 3, 2025
…pache#8296) **What changes were proposed in this pull request?** In `TestModelMetaService.java`, the tests testInsertAndUpdateModelComment and testInsertAndUpdateModelProperties were incorrectly setting the name and comment fields. This PR fixes the assignments so that name and comment are updated correctly according to the test's intent. **Why are the changes needed?** Previously, the tests would either overwrite the name with a comment value or keep the comment unchanged, causing the tests to not properly verify updates. Fixing the assignments ensures that comment updates and property updates are correctly tested. Fixes: apache#8282 **Does this PR introduce any user-facing change?** No. This only fixes test behavior. **How was this patch tested?** - Corrected field assignments in the affected tests. - Verified that `testInsertAndUpdateModelComment` correctly updates the comment without changing the name. - Verified that `testInsertAndUpdateModelProperties` correctly maintains the name and updates properties. - Ran all existing tests to confirm no regressions.
bharos
pushed a commit
to bharos/gravitino
that referenced
this pull request
Oct 7, 2025
…pache#8296) **What changes were proposed in this pull request?** In `TestModelMetaService.java`, the tests testInsertAndUpdateModelComment and testInsertAndUpdateModelProperties were incorrectly setting the name and comment fields. This PR fixes the assignments so that name and comment are updated correctly according to the test's intent. **Why are the changes needed?** Previously, the tests would either overwrite the name with a comment value or keep the comment unchanged, causing the tests to not properly verify updates. Fixing the assignments ensures that comment updates and property updates are correctly tested. Fixes: apache#8282 **Does this PR introduce any user-facing change?** No. This only fixes test behavior. **How was this patch tested?** - Corrected field assignments in the affected tests. - Verified that `testInsertAndUpdateModelComment` correctly updates the comment without changing the name. - Verified that `testInsertAndUpdateModelProperties` correctly maintains the name and updates properties. - Ran all existing tests to confirm no regressions.
danhuawang
pushed a commit
to danhuawang/gravitino
that referenced
this pull request
Jun 9, 2026
…pache#8296) **What changes were proposed in this pull request?** In `TestModelMetaService.java`, the tests testInsertAndUpdateModelComment and testInsertAndUpdateModelProperties were incorrectly setting the name and comment fields. This PR fixes the assignments so that name and comment are updated correctly according to the test's intent. **Why are the changes needed?** Previously, the tests would either overwrite the name with a comment value or keep the comment unchanged, causing the tests to not properly verify updates. Fixing the assignments ensures that comment updates and property updates are correctly tested. Fixes: apache#8282 **Does this PR introduce any user-facing change?** No. This only fixes test behavior. **How was this patch tested?** - Corrected field assignments in the affected tests. - Verified that `testInsertAndUpdateModelComment` correctly updates the comment without changing the name. - Verified that `testInsertAndUpdateModelProperties` correctly maintains the name and updates properties. - Ran all existing tests to confirm no regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
TestModelMetaService.java, the tests testInsertAndUpdateModelComment and testInsertAndUpdateModelProperties were incorrectly setting the name and comment fields. This PR fixes the assignments so that name and comment are updated correctly according to the test's intent.Why are the changes needed?
Previously, the tests would either overwrite the name with a comment value or keep the comment unchanged, causing the tests to not properly verify updates. Fixing the assignments ensures that comment updates and property updates are correctly tested.
Fixes: #8282
Does this PR introduce any user-facing change?
No. This only fixes test behavior.
How was this patch tested?
testInsertAndUpdateModelCommentcorrectly updates the comment without changing the name.testInsertAndUpdateModelPropertiescorrectly maintains the name and updates properties.