-
Notifications
You must be signed in to change notification settings - Fork 10
fix: scope webjars as testAndDevelopmentOnly
#600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: scope webjars as testAndDevelopmentOnly
#600
Conversation
Previously, `webjars` were marked as `developmentOnly`, which excluded them from integration tests. By using `testAndDevelopmentOnly`, they are now available in both development and test environments.
|
This will need a few changes in GradleConfiguration to map the Scope to a GradleConfiguration. Something like: The failure is unrelated to this change: |
|
Also seeing the assetCompile error on: #596 |
jamesfredley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great.
|
Merging since we need part of this for #596 |
|
I noticed that the tests are failing and this code exists in the asset pipeline: https://github.com/wondrify/asset-pipeline/blob/00db3ef6b137e7fab84b5b9f5a7d687fa844283f/asset-pipeline-gradle/src/main/groovy/asset/pipeline/gradle/AssetPipelinePlugin.groovy#L116 Doesn't that mean we should revert this change? Since the developmentOnly assets will be added to the test run classpath? @matrei @jamesfredley |
No, this change puts the actual webjars on the |
|
But according to that link, the testRuntimeClasspath extends the development runtimeOnly. It looks like this is now broken for dev too because of wondrify/asset-pipeline#380 |
I think |
|
I completely read that configuration wrong. Yes, this is the right change. thank you! |
Previously,
webjarswere marked asdevelopmentOnly, which excluded them from integration tests.By using
testAndDevelopmentOnly, they are now available in both development and test environments.