Restructure grails-forge build #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfredley
approved these changes
Jun 13, 2025
matrei
reviewed
Jun 14, 2025
grails-forge-core/src/test/groovy/org/grails/forge/build/gradle/GradleSpec.groovy
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@matrei I believe I've implemented all of you feedback except the .configure { } suggestion we've talked about previously. I'd like to defer that to another change if that's ok. |
Contributor
|
It seems there is a test failure: > Task :runCommand
Application class not found |
Contributor
Author
Apparently the args() of JavaExec do not like providers. I opened apache/grails-core#14816 to address this. Once that PR is merged, this PR will pass. |
Contributor
Author
|
The scaffolding spec is fixed. |
jamesfredley
approved these changes
Jun 24, 2025
matrei
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial rework on the grails-forge build to move away from buildSrc plugins and to start isolating micronaut related configuration to the individual projects