Skip to content

Conversation

@jeffscottbrown
Copy link
Contributor

Do you have any relevant unit tests? Thanks for the help.

@demon101
Copy link
Contributor Author

no, sorry

@jeffscottbrown
Copy link
Contributor

The following tests in grails-test-suite-web start failing after these changes are applied...

  • RegexUrlMappingTests.testNullableConstraintsInMapping
  • ReverseUrlMappingTests.testLinkTagRendering
  • LinkRenderingTagLibTests.testMappingsWhichSpecifyAPlugin
  • LinkRenderingTagLibTests.testOverlappingReverseMappings
  • LinkRenderingTagLibTests.testRenderLinkWithReverseMapping

@demon101
Copy link
Contributor Author

How I can start tests? By 'gradle test' I got same results with https://travis-ci.org/grails/grails-core/builds/47338166. Same errors I got before my changes
I will write tests tonight

@jeffscottbrown
Copy link
Contributor

./gradlew :grails-test-suite-web:test

@demon101
Copy link
Contributor Author

Fix has been fixed =)
Sorry for mistake. The code is very confusing

@jeffscottbrown
Copy link
Contributor

Will do another review soon. Thanks again for the help.

@demon101
Copy link
Contributor Author

any news?

jeffscottbrown added a commit that referenced this pull request Jan 22, 2015
@jeffscottbrown jeffscottbrown merged commit 487749f into apache:2.4.x Jan 22, 2015
@jeffscottbrown
Copy link
Contributor

Does this resolve both GRAILS-11863 and GRAILS-11864?

@demon101
Copy link
Contributor Author

Yes, for both.

@demon101
Copy link
Contributor Author

when tasks will be marked as fixed?

jdaugherty pushed a commit that referenced this pull request Apr 17, 2025
Added link to api docs for SupportsClassNode
jdaugherty pushed a commit that referenced this pull request Apr 17, 2025
jdaugherty pushed a commit that referenced this pull request Apr 22, 2025
Update dependency gradle to v7.6.3
jdaugherty pushed a commit to jdaugherty/grails-core that referenced this pull request Jun 28, 2025
Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants