Fix: Preserve deterministic Map ordering in UrlMappingsInfoHandlerAdapter #15284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported in #15281.
Starting from Grails 3.x, the framework switched to using
HashMapwhen assembling the controller result model.Because
HashMapdoes not guarantee insertion order, Maps returned by controllers may reach interceptors and filters with their fields in a different order than the one originally defined.This behavior has continued unchanged up to the current releases.
This PR updates the implementation of
UrlMappingsInfoHandlerAdapterto useLinkedHashMap, restoring deterministic ordering consistent with Grails 2.Only the relevant code path was modified, and no additional behavior was affected.