Issue 14379 remove dependency to tomcat embed logging log4j #15275
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency 'tomcat-embed-logging-log4j' is old, unmaintained and should not be used. Updated Hibernate documentation and example apache#14379
The GraphQL code is not active in the grails-core project but I removed the dependency anyway - it should not be there if we reintroduce the code again.
jdaugherty
reviewed
Dec 10, 2025
| implementation "org.apache.grails.data:grails-data-hibernate5-core" | ||
| runtimeOnly "com.h2database" | ||
| runtimeOnly "org.apache.tomcat:tomcat-jdbc" | ||
| runtimeOnly "org.slf4j:slf4j-nop" |
Contributor
There was a problem hiding this comment.
Why recommend nop instead of api? Don't we want the slf4j logging?
Contributor
Author
There was a problem hiding this comment.
I just picked the bare minimum - using api is probably a better choise, for a more realistic example.
I wrote a short example for testing, and added nop to get rid of this message:
> Task :Main.main()
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
Contributor
There was a problem hiding this comment.
Shouldn't slf4j-api only be used as implementation or compileOnly (if it is provided) and only if the slf4j API is used in the implementation of a library. In that case the downstream user chooses the runtime implementation. In this case, I think a slf4j implementation (like slf4j-nop) is the right choice.
matrei
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 14379 Remove dependency to tomcat-embed-logging-log4j
Fixes #14379
The dependency
tomcat-embed-logging-log4jis old, unmaintained andshould not be used.
Updated Hibernate documentation and related example.
Removed
tomcat-embed-logging-log4jdependency from GraphQLThe GraphQL code is not active in the grails-core project but I removed
the dependency anyway - it should not be there if we reintroduce the
code again.