Skip to content

Conversation

@jdaugherty
Copy link
Contributor

@jdaugherty jdaugherty commented Dec 2, 2025

@jdaugherty
Copy link
Contributor Author

jdaugherty commented Dec 2, 2025

I reordered the names alphabetically by section.

@jdaugherty jdaugherty force-pushed the authorship-changes branch 2 times, most recently from a4d5a9e to 5039a82 Compare December 4, 2025 03:40
@jdaugherty jdaugherty force-pushed the authorship-changes branch 2 times, most recently from dbd6253 to ef3a088 Compare December 4, 2025 04:00
@jdaugherty jdaugherty marked this pull request as ready for review December 4, 2025 16:07
@jdaugherty jdaugherty requested a review from matrei December 4, 2025 16:07
pomDeveloper('Contributor', id, name, project)
}

private static MavenPomDeveloper pomDeveloper(String role, String id, String name, Project project) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A developer can have more than one role (and also other properties).
Should we take that into account from the start?
On the other hand, these methods are all private so we can easily adjust later if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal was to only give them one role for simplicity. Technically almost all of the founders are inactive (well Graeme has responded when asked directly), but they're not actively maintaining the framework anymore. I modeled our approach after Groovy's approach.

@jdaugherty jdaugherty merged commit 79ceeeb into 7.0.x Dec 5, 2025
7 of 8 checks passed
@jdaugherty jdaugherty deleted the authorship-changes branch December 5, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants