-
-
Notifications
You must be signed in to change notification settings - Fork 971
Moving to a shared author/developer list #15274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cca0b41 to
1ef5d01
Compare
|
I reordered the names alphabetically by section. |
a4d5a9e to
5039a82
Compare
dbd6253 to
ef3a088
Compare
ef3a088 to
bf4cf70
Compare
6bae1eb to
fe2b6dc
Compare
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/PublishPlugin.groovy
Show resolved
Hide resolved
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/PublishPlugin.groovy
Outdated
Show resolved
Hide resolved
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/PublishPlugin.groovy
Outdated
Show resolved
Hide resolved
| pomDeveloper('Contributor', id, name, project) | ||
| } | ||
|
|
||
| private static MavenPomDeveloper pomDeveloper(String role, String id, String name, Project project) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A developer can have more than one role (and also other properties).
Should we take that into account from the start?
On the other hand, these methods are all private so we can easily adjust later if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My proposal was to only give them one role for simplicity. Technically almost all of the founders are inactive (well Graeme has responded when asked directly), but they're not actively maintaining the framework anymore. I modeled our approach after Groovy's approach.
See https://lists.apache.org/thread/c33fx3djh17tl67y0g3szhvsq98cq2jc