Do not mark AST transformation methods as generated #15214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This appears to be a follow-up to #15150 |
Contributor
|
Given that we made this change on 10/17 and it recently was released, I'm going to go ahead and merge this since it's basically a revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #15150
Jacoco isn't displaying coverage lines on methods annotated with Transactional (or other annotation that apply AST transformation).
I think that has been applied to display a more clean list of methods in the tree, but I guess the coverage lines is more important than that.
I did some tests and below you can see the results.
Current
No coverage lines are displayed.
Marking the original method as generated
I don't think this is the best way, it feels counterintuitive to me.
Not marking methods as generated
It has a larger methods list than other ways.
I chose not to mark the methods as generated, let me know what you think.