15048 - feature: reproducible gorm service implementations #15097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
force-pushed
the
reproducibleGormServices
branch
from
392872f to
c282f70
Compare
jamesfredley
approved these changes
Sep 24, 2025
matrei
reviewed
Sep 25, 2025
|
|
||
| } | ||
|
|
||
| propertiesFields.sort(true) { it.name } // ensure a consistent order of processing fields |
Contributor
There was a problem hiding this comment.
Can be removed if we use a sorted set.
| boolean isInterface = classNode.isInterface() | ||
| boolean isAbstractClass = !isInterface && Modifier.isAbstract(classNode.modifiers) | ||
|
|
||
| List<FieldNode> propertiesFields = [] |
Contributor
There was a problem hiding this comment.
- Use a sorted set from the start? Would eliminate the need to sort after the loop.
// Use sorted set to ensure consistent ordering for build reproducibility
def propertiesFields = new TreeSet<FieldNode>({ FieldNode a, FieldNode b -> a.name <=> b.name })
Comment on lines
264
to
+266
| List<MethodNode> abstractMethods = findAllUnimplementedAbstractMethods(classNode) | ||
| abstractMethods.sort(true) { it.name } // ensure a consistent order of processing methods | ||
|
|
Contributor
There was a problem hiding this comment.
Sort inline? Simplify?
// Sort to ensure consistent ordering for build reproducibility
def abstractMethods = findAllUnimplementedAbstractMethods(classNode)
.sort { it.name }
Comment on lines
+271
to
+272
| def sortedMethods = classNode.methods.sort(true) { it.name } | ||
| for (MethodNode existing in (sortedMethods)) { |
Contributor
There was a problem hiding this comment.
- Add comment why we are sorting?
- Why mutate?
- Simplify?
// Sort to ensure consistent ordering for build reproducibility
def sortedMethods = classNode.methods.sort { it.name }
for (MethodNode existing in sortedMethods) {| List<FieldNode> propertiesFields = [] | ||
| if (isAbstractClass) { | ||
| List<PropertyNode> properties = classNode.getProperties() | ||
| List<PropertyNode> properties = classNode.getProperties().sort { it.name } |
Contributor
There was a problem hiding this comment.
- Add comment why we are sorting?
- Simplify?
// Sort to ensure consistent ordering for build reproducibility
def properties = classNode.properties.sort { it.name }|
|
||
| Iterable<ServiceImplementerAdapter> adapters = load(ServiceImplementerAdapter) | ||
| List<ServiceImplementerAdapter> finalAdapters = adapters.toList() | ||
| List<ServiceImplementerAdapter> finalAdapters = adapters.toList().sort { it.class.name } |
Contributor
There was a problem hiding this comment.
- Add comment why we are sorting?
- Simplify?
// Sort to ensure consistent ordering for build reproducibility
def finalAdapters = adapters.sort { it.class.name }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15048 , but I think the AclIdentityObject in spring security will still differ after this change. From local testing, the closures are generated in the same order - we can confirm this as part of the next release.