Remove additivity attribute from StackTrace logger #15066
Conversation
Prevents: WARN in Logger[StackTrace] - No appenders present in context [default] for logger [StackTrace]. The 'additivity="false"' attribute was removed from the StackTrace logger configuration in multiple logback-spring.xml files and the logback.rocker.raw template. This change simplifies the logger configuration and ensures it extends the root logger.
jamesfredley
requested review from
jdaugherty and
matrei
and removed request for
jdaugherty
jdaugherty
left a comment
jdaugherty
left a comment
There was a problem hiding this comment.
So we're saying we should effectively configure all loggers as the root loggers and not allow messages to go to multiple logs? Isn't the additivity configuration so that an exception logs to both the console log + an error log?
matrei
left a comment
matrei
left a comment
There was a problem hiding this comment.
Good catch! With no appender and additivity disabled, events didn’t bubble up and were discarded.
|
The default generated logback config throws the following error when there is an exception in a controller. I am not sure how it made it ~1 year that way, but this was focused on resolving that issue.
I did not explore "exception logs to both the console log + an error log", just resolved the issue above, but the end user could go in that direction instead of the default generated simpler config. |
3 participants
Prevents:
WARN in Logger[StackTrace] - No appenders present in context [default] for logger [StackTrace].The 'additivity="false"' attribute was removed from the StackTrace logger configuration in multiple logback-spring.xml files and the logback.rocker.raw template. This change simplifies the logger configuration and ensures it extends the root logger.