Skip to content

Remove springloaded forge feature, it only works with JDK 8 or less #14992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamesfredley merged 1 commit into from
Aug 18, 2025
Merged

Remove springloaded forge feature, it only works with JDK 8 or less #14992

jamesfredley merged 1 commit into from
Aug 18, 2025

Conversation

@jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Aug 18, 2025 •
edited
Loading

grails-core/grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/reloading/Springloaded.java

Lines 56 to 72 in 8497491

public void processSelectedFeatures(FeatureContext featureContext) {
int jdkVersion = featureContext.getJavaVersion().majorVersion();
if (jdkVersion >= 9) {
Springloaded springloaded = this;
featureContext.exclude(new FeaturePredicate() {
@Override
public boolean test(Feature feature) {
return feature == springloaded;
}
@Override
public Optional<String> getWarning() {
return Optional.of("Springloaded was excluded because it does not support JDK " + jdkVersion);
}
});
}
}

@jamesfredley jamesfredley self-assigned this Aug 18, 2025
@jamesfredley jamesfredley moved this to In Progress in Apache Grails Aug 18, 2025
@jamesfredley jamesfredley added this to the grails:7.0.0-RC2 milestone Aug 18, 2025
@jamesfredley jamesfredley linked an issue Aug 18, 2025 that may be closed by this pull request
Grails Forge - remove spring loaded feature #14980
Closed
@jamesfredley jamesfredley merged commit 3a8f7fa into 7.0.x Aug 18, 2025
33 checks passed
@jamesfredley jamesfredley deleted the remove-springloaded-feature branch August 18, 2025 23:46
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache Grails Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdaugherty jdaugherty jdaugherty approved these changes

@sbglasius sbglasius Awaiting requested review from sbglasius

@matrei matrei Awaiting requested review from matrei

Assignees

@jamesfredley jamesfredley

Labels

None yet

Projects

Apache Grails
Status: Done

Milestone

grails:7.0.0-RC2

Development

Successfully merging this pull request may close these issues.

Grails Forge - remove spring loaded feature

2 participants

@jamesfredley @jdaugherty