#14886 - add licensing to distributed shadowJar #14945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
force-pushed
the
shadowJarLicensing
branch
from
ec7f6e8 to
196a81f
Compare
jamesfredley
reviewed
Aug 1, 2025
jamesfredley
approved these changes
Aug 1, 2025
matrei
approved these changes
Aug 2, 2025
...orge/buildSrc/src/main/groovy/org/apache/grails/buildsrc/GrailsShadowLicenseTransform.groovy
Outdated
Show resolved
Hide resolved
...orge/buildSrc/src/main/groovy/org/apache/grails/buildsrc/GrailsShadowLicenseTransform.groovy
Show resolved
Hide resolved
...orge/buildSrc/src/main/groovy/org/apache/grails/buildsrc/GrailsShadowLicenseTransform.groovy
Show resolved
Hide resolved
...orge/buildSrc/src/main/groovy/org/apache/grails/buildsrc/GrailsShadowLicenseTransform.groovy
Show resolved
Hide resolved
...forge/buildSrc/src/main/groovy/org/apache/grails/buildsrc/GrailsShadowNoticeTransform.groovy
Outdated
Show resolved
Hide resolved
...forge/buildSrc/src/main/groovy/org/apache/grails/buildsrc/GrailsShadowNoticeTransform.groovy
Outdated
Show resolved
Hide resolved
jdaugherty
force-pushed
the
shadowJarLicensing
branch
from
1af6afc to
2191a0c
Compare
jamesfredley
approved these changes
Aug 3, 2025
Contributor
jamesfredley
left a comment
jamesfredley
left a comment
There was a problem hiding this comment.
I retested with the latest changes and the SLF4J messages are gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add licensing / notice / disclaimer to the grails-cli.jar. It removes publishing for the grails-forge-cli shadow jar.
Please note: as part of this work, I think we need to enable the licensing plugin added by Sergio. I noticed the grails-core project exports the Jakarta annotations API, which is dual licensed under GPL & Eclipse. For now, I've updated our notice files to say which one we choose.
We may want to revisit this approach for the shadowJar and instead generate a combined file, check it in, and then every build generate one. If it changes, we know the licenses have changed and need updated (so fail the build until updated). This would allow us to manually curate the shadowJar license information.
This is out of scope for the RC1 though, and this PR at least makes our licensing consistent so I'd like to move forward with this as a start.