Update base, web and rest-api profiles to more closely match Forge #14942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
reviewed
Aug 1, 2025
…ated applications
jdaugherty
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For web and rest-api profiles, plus necessary adjustments to base, this PR adjusts the dependencies to match the default dependencies generated by Forge. There will likely be some debate regarding which is correct, but this is a starting place.
We still need to find a better solution for
integrationTestImplementation testFixtures("org.apache.grails:grails-geb")which lives in base/skeleton/build.gradle and is currently applied for all profiles, since the yml conversion does not supporttestFixtures(""). #14943plugin and web-plugin have significant differences to discuss before making changes: #14944