-
-
Notifications
You must be signed in to change notification settings - Fork 971
Merge grails-forge into grails-core #14836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only add Apache Snapshot repository when grailsVersion ends in SNAPSHOT
Always upload artifacts to workflow summary page
Upload CLI Zip to Workflow Summary Page
|
I think this should be ready to review now. A long the way, I found more issues:
|
matrei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work James, thank you!
Some nitpicking and questions?
...le/plugins/src/main/groovy/org/grails/gradle/plugin/publishing/GrailsPublishExtension.groovy
Outdated
Show resolved
Hide resolved
...le/plugins/src/main/groovy/org/grails/gradle/plugin/publishing/GrailsPublishExtension.groovy
Outdated
Show resolved
Hide resolved
grails-gradle/tasks/src/main/groovy/org/grails/gradle/plugin/run/FindMainClassTask.groovy
Outdated
Show resolved
Hide resolved
|
I did notice that the license headers are different in the forge projects, still using the |
jamesfredley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b4b02d7...jdaugherty:grails-core:grails-forge-merge looked good
DISCLAIMER, LICENSE, NOTICE and INSTALL files are missing from grails-cli distribution zip.
The buildSrc feature is still flakey, but we should handle that separately. Application generation from grails-cli works great.
The forge tests are failing on Windows, I believe due to the following, but I have not yet found a solution that is working.
maven {
name = 'TestCaseMavenRepo'
url = testRepoPath
}
Concerning the windows path, @jamesfredley can you try adding |
This PR merges grails-forge into grails-core per vote [1].
[1] https://lists.apache.org/thread/xt10lmr75tj9xo4j60y60hss1t76wt3f