-
-
Notifications
You must be signed in to change notification settings - Fork 971
fix: scope webjars as testAndDevelopmentOnly #14829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not sure we need to add |
|
I was glad to remove |
|
That's interesting. Gradle seems to be able to resolve the webjar versions in apps generated by Forge, without the platform added. |
|
Aha, this is why the platform is needed in the functional test apps:
|
|
Based on grails-core/gradle/grails-extension-gradle-config.gradle Lines 28 to 34 in ead0035
Given we use project() in these test projects, it appears we need to keep the dependency management plugin disabled and add grails-bom as a platform for testAndDevelopmentOnly. This is different than generated apps, but we are moving in this direction: #14142 |
This reverts commit cbe5b31.
Apply changes from apache/grails-forge#600