-
-
Notifications
You must be signed in to change notification settings - Fork 971
Update Geb documentation changes in Breaking Changes Section #14793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Geb documentation changes in Breaking Changes Section #14793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates documentation references to the migrated Apache repository and adds a new breaking-changes entry for the container runtime requirement.
- Consolidates all plugin/test links from
grails/gebtoapache/grails-core - Introduces section 12.9 in the upgrading guide to require a container runtime for Geb tests
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| grails-test-examples/geb/src/integration-test/groovy/org/demo/spock/ContainerFileDetectorSpockSpec.groovy | Updated the @PendingFeature link to the Apache repo |
| grails-geb/src/main/groovy/grails/plugin/geb/GebGrailsPlugin.groovy | Pointed documentation, issue tracker, and SCM URLs to apache/grails-core |
| grails-doc/src/en/ref/Command Line/plugin-info.adoc | Aligned documentation, issue tracker, and source URLs |
| grails-doc/src/en/guide/upgrading/upgrading60x.adoc | Added section for container runtime requirement |
| grails-doc/src/en/guide/introduction/whatsNew.adoc | Updated plugin link to new Apache repo path |
Comments suppressed due to low confidence (2)
grails-doc/src/en/guide/upgrading/upgrading60x.adoc:285
- [nitpick] Consider adding a section anchor (e.g.,
[[container-runtime-required]]) above this heading to allow stable cross-references in the documentation.
===== 12.9 Container runtime environment is now required for standard Geb functional and integration tests
grails-doc/src/en/guide/upgrading/upgrading60x.adoc:301
- [nitpick] To improve usability, consider adding direct links to each listed container runtime’s installation or setup guide.
- **Docker Desktop**
...xamples/geb/src/integration-test/groovy/org/demo/spock/ContainerFileDetectorSpockSpec.groovy
Show resolved
Hide resolved
JudeRV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
of Upgrading from Grails 6 to Grails 7
Co-authored-by: Copilot <[email protected]>
1be5ffc to
dd3888b
Compare
This is similar to documentation in the
what's newsection, but is more focused on thecontainer runtime requirementwhich when missing will cause tests to fail.