Skip to content

Conversation

@jamesfredley
Copy link
Contributor

This is similar to documentation in the what's new section, but is more focused on the container runtime requirement which when missing will cause tests to fail.

@jamesfredley jamesfredley added this to the grails:7.0.0-RC1 milestone Jun 9, 2025
@jamesfredley jamesfredley self-assigned this Jun 9, 2025
@jamesfredley jamesfredley requested a review from Copilot June 9, 2025 22:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates documentation references to the migrated Apache repository and adds a new breaking-changes entry for the container runtime requirement.

  • Consolidates all plugin/test links from grails/geb to apache/grails-core
  • Introduces section 12.9 in the upgrading guide to require a container runtime for Geb tests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
grails-test-examples/geb/src/integration-test/groovy/org/demo/spock/ContainerFileDetectorSpockSpec.groovy Updated the @PendingFeature link to the Apache repo
grails-geb/src/main/groovy/grails/plugin/geb/GebGrailsPlugin.groovy Pointed documentation, issue tracker, and SCM URLs to apache/grails-core
grails-doc/src/en/ref/Command Line/plugin-info.adoc Aligned documentation, issue tracker, and source URLs
grails-doc/src/en/guide/upgrading/upgrading60x.adoc Added section for container runtime requirement
grails-doc/src/en/guide/introduction/whatsNew.adoc Updated plugin link to new Apache repo path
Comments suppressed due to low confidence (2)

grails-doc/src/en/guide/upgrading/upgrading60x.adoc:285

  • [nitpick] Consider adding a section anchor (e.g., [[container-runtime-required]]) above this heading to allow stable cross-references in the documentation.
===== 12.9 Container runtime environment is now required for standard Geb functional and integration tests

grails-doc/src/en/guide/upgrading/upgrading60x.adoc:301

  • [nitpick] To improve usability, consider adding direct links to each listed container runtime’s installation or setup guide.
- **Docker Desktop**

Copy link
Contributor

@JudeRV JudeRV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamesfredley jamesfredley linked an issue Jun 9, 2025 that may be closed by this pull request
@jdaugherty jdaugherty force-pushed the geb-documentation-changes branch from 1be5ffc to dd3888b Compare June 10, 2025 13:52
@jdaugherty jdaugherty merged commit 1d49052 into apache:7.0.x Jun 10, 2025
19 of 25 checks passed
@jamesfredley jamesfredley deleted the geb-documentation-changes branch June 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add Geb with Testcontainers sections to Breaking changes section

4 participants