[GLUTEN-8497][VL] Fix columnar batch type mismatch in table cache#9230
Merged
zhztheplayer merged 2 commits intoapache:mainfrom Apr 10, 2025
Merged
[GLUTEN-8497][VL] Fix columnar batch type mismatch in table cache#9230zhztheplayer merged 2 commits intoapache:mainfrom
zhztheplayer merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the test case added in #8498.
The patch conditionally adds a
ColumnarToRowRemovalGuardnode that does nothing on top of awhich is to be cached to avoid this Spark code from removing the C2R, the plan will become:
which will be treated as regular row-based plan by
ColumnarCachedBatchSerializerthen be handled with vanilla Spark batch serializer.Previously, there was an columnar batch type mismatch error because Spark's cache planner removes the top
ColumnarToRowbut treats the remaining of the plan as vanilla Spark columnar plan.