Skip to content

[GLUTEN-8627][VL] Fix cpp build and build script on MacOS#8628

Merged
zhouyuan merged 1 commit intoapache:mainfrom
marin-ma:build-on-darwin
Jan 28, 2025
Merged

[GLUTEN-8627][VL] Fix cpp build and build script on MacOS#8628
zhouyuan merged 1 commit intoapache:mainfrom
marin-ma:build-on-darwin

Conversation

@marin-ma
Copy link
Copy Markdown
Contributor

@marin-ma marin-ma commented Jan 27, 2025 •
edited
Loading

Fix the cpp compilation error and make builddeps-veloxbe.sh work on MacOS.

Manually tested with ./dev/builddeps-veloxbe.sh --run_setup_script=ON --build_arrow=ON --build_type=Debug --build_tests=ON --build_examples=ON and also tested with switching OFF the build options and Release build type.

Note --build_benchmarks=ON still fails because the function to set CPU affinity on macOS is not supported. I will fix that in a separate patch.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 27, 2025

#8627

@marin-ma
Copy link
Copy Markdown
Contributor Author

marin-ma commented Jan 27, 2025

@FelixYBW @zhouyuan Could you help to review? Thanks!

zhouyuan
zhouyuan approved these changes Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
All CI green

@zhouyuan zhouyuan merged commit 80ffbf1 into apache:main Jan 28, 2025
@GlutenPerfBot
Copy link
Copy Markdown
Contributor

GlutenPerfBot commented Jan 28, 2025

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_01_28_2025_time.csv log/native_master_01_27_2025_cd7c790ea4_time.csv difference percentage
q1 15.86 16.01 0.150 100.95%
q2 15.94 16.56 0.622 103.90%
q3 4.88 5.02 0.147 103.00%
q4 85.33 86.08 0.751 100.88%
q5 12.34 11.46 -0.877 92.89%
q6 4.76 3.56 -1.195 74.88%
q7 8.55 8.80 0.249 102.91%
q8 6.26 4.64 -1.614 74.21%
q9 28.41 28.26 -0.148 99.48%
q10 12.58 13.10 0.514 104.09%
q11 43.53 42.07 -1.466 96.63%
q12 2.28 3.10 0.820 135.95%
q13 9.20 7.98 -1.214 86.80%
q14a 65.05 61.25 -3.801 94.16%
q14b 57.74 58.08 0.344 100.60%
q15 3.39 3.79 0.400 111.81%
q16 29.04 29.34 0.298 101.03%
q17 7.35 7.95 0.597 108.13%
q18 10.62 10.01 -0.611 94.24%
q19 5.05 4.53 -0.517 89.75%
q20 2.24 2.61 0.370 116.54%
q21 1.62 1.50 -0.119 92.68%
q22 9.81 9.78 -0.037 99.62%
q23a 135.70 135.82 0.125 100.09%
q23b 161.03 160.32 -0.709 99.56%
q24a 103.37 105.61 2.237 102.16%
q24b 96.93 106.34 9.417 109.72%
q25 6.66 8.44 1.777 126.68%
q26 4.86 5.26 0.399 108.22%
q27 5.95 5.86 -0.087 98.54%
q28 37.74 38.70 0.959 102.54%
q29 19.78 16.76 -3.025 84.71%
q30 6.47 6.41 -0.056 99.14%
q31 10.20 10.16 -0.035 99.65%
q32 1.97 2.21 0.241 112.25%
q33 7.19 7.18 -0.013 99.81%
q34 4.41 4.46 0.043 100.96%
q35 10.19 10.55 0.366 103.59%
q36 5.76 5.43 -0.329 94.28%
q37 5.22 5.17 -0.052 99.00%
q38 18.08 17.82 -0.262 98.55%
q39a 4.90 4.47 -0.428 91.27%
q39b 4.71 5.00 0.285 106.05%
q40 5.30 5.74 0.440 108.30%
q41 1.13 0.97 -0.155 86.24%
q42 1.35 1.26 -0.090 93.34%
q43 4.49 4.53 0.040 100.90%
q44 11.55 13.38 1.831 115.86%
q45 5.83 4.36 -1.473 74.74%
q46 5.30 5.66 0.365 106.90%
q47 20.76 21.35 0.587 102.83%
q48 6.62 6.24 -0.376 94.32%
q49 10.30 10.98 0.681 106.61%
q50 38.00 38.61 0.616 101.62%
q51 14.38 14.19 -0.200 98.61%
q52 1.31 1.41 0.102 107.82%
q53 3.16 3.16 -0.005 99.84%
q54 6.96 7.23 0.262 103.76%
q55 1.33 3.08 1.748 231.45%
q56 8.92 7.00 -1.917 78.50%
q57 13.35 14.25 0.899 106.73%
q58 4.22 3.50 -0.726 82.81%
q59 7.20 8.61 1.411 119.61%
q60 8.33 8.50 0.161 101.94%
q61 8.55 8.36 -0.193 97.74%
q62 5.27 4.93 -0.346 93.43%
q63 3.14 3.07 -0.072 97.70%
q64 63.17 62.15 -1.018 98.39%
q65 30.44 30.08 -0.357 98.83%
q66 4.30 4.65 0.345 108.02%
q67 227.74 229.69 1.945 100.85%
q68 4.12 4.35 0.232 105.64%
q69 6.92 6.88 -0.036 99.48%
q70 11.89 12.69 0.794 106.68%
q71 4.62 4.72 0.100 102.17%
q72 39.56 40.28 0.724 101.83%
q73 3.25 3.73 0.477 114.69%
q74 27.44 26.76 -0.676 97.54%
q75 43.73 44.44 0.711 101.63%
q76 14.34 14.36 0.021 100.15%
q77 4.40 3.64 -0.764 82.65%
q78 83.90 83.95 0.049 100.06%
q79 5.13 4.97 -0.160 96.88%
q80 17.22 16.75 -0.475 97.24%
q81 8.43 8.27 -0.162 98.08%
q82 10.29 10.14 -0.147 98.57%
q83 2.95 2.86 -0.094 96.82%
q84 3.64 3.45 -0.189 94.81%
q85 9.75 9.59 -0.163 98.33%
q86 4.51 4.51 0.004 100.10%
q87 19.04 18.14 -0.894 95.30%
q88 23.69 22.99 -0.698 97.05%
q89 4.37 4.85 0.476 110.89%
q90 3.44 3.63 0.183 105.32%
q91 5.68 6.04 0.358 106.30%
q92 2.69 1.98 -0.710 73.60%
q93 54.56 54.33 -0.227 99.58%
q94 16.65 17.06 0.417 102.50%
q9 99.75 97.78 -1.972 98.02%
q5 3.26 3.33 0.068 102.09%
q96 28.05 28.22 0.167 100.60%
q97 2.70 3.03 0.328 112.15%
q98 10.22 10.02 -0.200 98.04%
q99 10.22 10.02 -0.200 98.04%
total 2195.54 2202.10 6.567 100.30%

baibaichen pushed a commit to baibaichen/gluten that referenced this pull request Feb 1, 2025
@marin-ma @baibaichen
[GLUTEN-8627][VL] Fix cpp build and build script on MacOS (apache#8628)
67faece 
Fix the cpp compilation error and make builddeps-veloxbe.sh work on MacOS.

Manually tested with ./dev/builddeps-veloxbe.sh --run_setup_script=ON --build_arrow=ON --build_type=Debug --build_tests=ON --build_examples=ON and also tested with switching OFF the build options and Release build type.

Note --build_benchmarks=ON still fails because the function to set CPU affinity on macOS is not supported. I will fix that in a separate patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhouyuan zhouyuan zhouyuan approved these changes

@FelixYBW FelixYBW FelixYBW approved these changes

Assignees

No one assigned

Labels

BUILD VELOX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marin-ma @GlutenPerfBot @zhouyuan @FelixYBW