[GLUTEN-8611][VL] Set VELOX_GFLAGS_TYPE by checking GLUTEN_VCPKG_ENABLED in build_velox.sh#8612
Merged
marin-ma merged 2 commits intoapache:mainfrom Jan 27, 2025
Merged
Conversation
Contributor
Author
|
@philo-he Could you help to review? Thanks! |
Contributor
philo-he
approved these changes
Jan 25, 2025
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Just one comment. Please confirm it.
ep/build-velox/src/build_velox.sh
Outdated
| echo "ENABLE_BENCHMARK is ON. Disabling Tests, GCS and ABFS connectors if enabled." | ||
| COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_BENCHMARKS=ON" | ||
| fi | ||
| if [ $ENABLE_VCPKG == "ON" ]; then |
Member
There was a problem hiding this comment.
Seems we can just rely on this check to see whether the below env variable is set:
if [ -n "${GLUTEN_VCPKG_ENABLED:-}" ];
Member
|
Initially this is required as we are using static packaging with VCPKG, so it makes sense by moving this to vcpkg related compilation |
marin-ma
changed the title
marin-ma
changed the title
Contributor
Author
baibaichen
pushed a commit
to baibaichen/gluten
that referenced
this pull request
Feb 1, 2025
…LED in build_velox.sh (apache#8612)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch we can remove oap-project/velox@885fbc6#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a