Skip to content

[GLUTEN-8497][CORE] A unified CallInfo API to replace AdaptiveContext#8551

Merged
zhztheplayer merged 8 commits intoapache:mainfrom
zhztheplayer:wip-callerinfo
Jan 17, 2025
Merged

[GLUTEN-8497][CORE] A unified CallInfo API to replace AdaptiveContext#8551
zhztheplayer merged 8 commits intoapache:mainfrom
zhztheplayer:wip-callerinfo

Conversation

@zhztheplayer
Copy link
Copy Markdown
Member

@zhztheplayer zhztheplayer commented Jan 16, 2025

Background:

The overall purpose is to add an API to determine whether a columnar rule call is for columnar table cache's cached plan's optimization, which is a subtask of #8497.

Solution:

Since we already have AdaptiveContext for similar purpose but for deciding whether the call is for AQE incremental optimization, the patch adds a new API CallInfo and incorporates both isAqe() (to replace AdaptiveContext) and isCache (for #8497) into it.

AdaptiveContext is removed in this PR.

@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Jan 16, 2025
@github-actions
Copy link
Copy Markdown

#8497

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Copy link
Copy Markdown
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhztheplayer zhztheplayer merged commit 13d9a17 into apache:main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLICKHOUSE CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants