[GLUTEN-8307][VL] Support Int64 Timestamp in parquet reader#8308
Merged
rui-mo merged 1 commit intoapache:mainfrom Jan 7, 2025
Merged
[GLUTEN-8307][VL] Support Int64 Timestamp in parquet reader#8308rui-mo merged 1 commit intoapache:mainfrom
rui-mo merged 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Member
|
CC @rui-mo |
Contributor
Author
|
Abnormal UT：
cc @rui-mo do you know the reason? |
Contributor
|
@zml1206 I'm glad to investigate them this week. Do you think it makes sense to hold on this PR for a while? |
Contributor
Author
Contributor
Hi @zml1206, I opened facebookincubator/velox#11964 to address above failed case. And I assume we can enable this unit test after the PR being merged.
This case doesn't seem to be relevant to the timestamp reader. I suggest we not enabling it in this PR. Thanks. |
Contributor
Author
facebookincubator/velox#11651, Is it the same problem? @rui-mo |
Contributor
|
@zml1206 Let me pick that PR to check if it is solved. Thanks for the pointer. |
Contributor
Author
Contributor
@zml1206 I picked that PR but strangely the test I suggest we do not enable this test in this PR for the reasons: 1) it is not timestamp related. 2) it depends on another in-progress PR. facebookincubator/velox#11964 has been merged, and the other timestamp tests could be enabled. |
Contributor
Author
OK, I'll do it, thank you. |
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@rui-mo Updated, can you help take.a look? thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
facebookincubator/velox#11530 add Int64 Timestamp in parquet reader, remove config VELOX_SCAN_FILE_SCHEME_VALIDATION_ENABLED and enable related ut.
(Fixes: #8307)
How was this patch tested?