[GLUTEN-7311][CH] Support grace aggregate algorithm in partial aggregating stages#7322
Merged
baibaichen merged 4 commits intoapache:mainfrom Oct 15, 2024
Merged
[GLUTEN-7311][CH] Support grace aggregate algorithm in partial aggregating stages#7322baibaichen merged 4 commits intoapache:mainfrom
baibaichen merged 4 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Contributor
|
Is there any performance improved with this pr ? |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
2 similar comments
Contributor
Author
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Contributor
Author
It's not for performance |
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Oct 15, 2024
baibaichen
added a commit
that referenced
this pull request
Oct 15, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241015) * Fix Build due to ClickHouse/ClickHouse#70135 * Resovle conflict with #7322 * gtest skip since plan is chagned due to #7395 (cherry picked from commit 94e1837a922d5a092226b195d6c3079d320878cb) --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #7311
For aggregations involve
distinct, use grace aggregate algorithm in partial aggregating stages, instead of streaming aggregating algorithm.Following changes are made
GraceAggregatingStep. It bases on codes ofGraceMergingAggregatedStep, and supports to generate intermediate result.Aggregatorto support multiple aggregate phases, change is in [GLUTEN-7311]A patch for supporting multiple aggregate phases in one step Kyligence/ClickHouse#504AggregateFunctionPartialMerge::getBaseAggregateFunctionWithSameStateRepresentation, resolve the failure of checking columns structure equality in aggregate phaseINTERMEDIATE_TO_INTERMEDIATErequiredChildDistributionExpressionsinMergeTwoPhasesHashBaseAggregatethat we can determine whether a aggregate step is in completed mode.How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests, manual tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)