Skip to content

[GLUTEN-7264][CORE][VL] Reduce module dependencies of gluten-data#7265

Merged
zhztheplayer merged 8 commits intoapache:mainfrom
zhztheplayer:wip-gluten-arrow
Sep 19, 2024
Merged

[GLUTEN-7264][CORE][VL] Reduce module dependencies of gluten-data#7265
zhztheplayer merged 8 commits intoapache:mainfrom
zhztheplayer:wip-gluten-arrow

Conversation

@zhztheplayer
Copy link
Copy Markdown
Member

@zhztheplayer zhztheplayer commented Sep 18, 2024

Part of #7264.

Make module gluten-data depend on gluten-core than on gluten-substrait for better code isolation.

graphviz

@zhztheplayer zhztheplayer marked this pull request as draft September 18, 2024 08:32
@github-actions github-actions bot added CORE works for Gluten Core VELOX RSS CLICKHOUSE labels Sep 18, 2024
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title [VL] Minimize module dependency of gluten-data [CORE][VL] Minimize module dependency of gluten-data Sep 18, 2024
@zhztheplayer zhztheplayer changed the title [CORE][VL] Minimize module dependency of gluten-data [GLUTEN-7264][CORE][VL] Minimize module dependency of gluten-data Sep 18, 2024
@apache apache deleted a comment from github-actions bot Sep 18, 2024
@github-actions
Copy link
Copy Markdown

#7264

@zhztheplayer zhztheplayer changed the title [GLUTEN-7264][CORE][VL] Minimize module dependency of gluten-data [GLUTEN-7264][CORE][VL] Reduce module dependencies of gluten-data Sep 18, 2024
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

1 similar comment
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review September 19, 2024 01:46
@zhztheplayer zhztheplayer merged commit 0c9a88f into apache:main Sep 19, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Sep 19, 2024
 - Use CHConf
 - use CHConf.prefixOf() instead of "spark.gluten.sql.columnar.backend.ch."
 - settingsKey => runtimeSettings
 - configKey => runtimeConfig
 - CH => CONF_PREFIX
baibaichen added a commit to baibaichen/gluten that referenced this pull request Sep 19, 2024
 - Use CHConf
 - use CHConf.prefixOf() instead of "spark.gluten.sql.columnar.backend.ch."
 - settingsKey => runtimeSettings
 - configKey => runtimeConfig
 - CH => CONF_PREFIX
baibaichen pushed a commit that referenced this pull request Sep 19, 2024
…etree module (#7279)

* Add CHConf

* Move MergeTree related UT to mergetree module

* fix scala stye

* spark32 spark33 spark35

* More CH Conf

* update per #7265

 - Use CHConf
 - use CHConf.prefixOf() instead of "spark.gluten.sql.columnar.backend.ch."
 - settingsKey => runtimeSettings
 - configKey => runtimeConfig
 - CH => CONF_PREFIX

* fix due to #7263
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
…etree module (apache#7279)

* Add CHConf

* Move MergeTree related UT to mergetree module

* fix scala stye

* spark32 spark33 spark35

* More CH Conf

* update per apache#7265

 - Use CHConf
 - use CHConf.prefixOf() instead of "spark.gluten.sql.columnar.backend.ch."
 - settingsKey => runtimeSettings
 - configKey => runtimeConfig
 - CH => CONF_PREFIX

* fix due to apache#7263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants