Skip to content

[GLUTEN-7262][CH] Fix cache file commond run normal with config disabled#7263

Merged
loneylee merged 3 commits intoapache:mainfrom
loneylee:7262
Sep 19, 2024
Merged

[GLUTEN-7262][CH] Fix cache file commond run normal with config disabled#7263
loneylee merged 3 commits intoapache:mainfrom
loneylee:7262

Conversation

@loneylee
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

(Fixes: #7262)

How was this patch tested?

Test by ut

@github-actions
Copy link
Copy Markdown

#7262

@loneylee loneylee marked this pull request as ready for review September 18, 2024 07:02
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

1 similar comment
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI

Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loneylee loneylee merged commit 87657f6 into apache:main Sep 19, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Sep 19, 2024
baibaichen pushed a commit that referenced this pull request Sep 19, 2024
…etree module (#7279)

* Add CHConf

* Move MergeTree related UT to mergetree module

* fix scala stye

* spark32 spark33 spark35

* More CH Conf

* update per #7265

 - Use CHConf
 - use CHConf.prefixOf() instead of "spark.gluten.sql.columnar.backend.ch."
 - settingsKey => runtimeSettings
 - configKey => runtimeConfig
 - CH => CONF_PREFIX

* fix due to #7263
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
…etree module (apache#7279)

* Add CHConf

* Move MergeTree related UT to mergetree module

* fix scala stye

* spark32 spark33 spark35

* More CH Conf

* update per apache#7265

 - Use CHConf
 - use CHConf.prefixOf() instead of "spark.gluten.sql.columnar.backend.ch."
 - settingsKey => runtimeSettings
 - configKey => runtimeConfig
 - CH => CONF_PREFIX

* fix due to apache#7263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CH] Cached path when config not enabled

3 participants