[GLUTEN-6705] [CORE] Refactor: Introduce GlutenCommitProtocol#6706
Closed
baibaichen wants to merge 1 commit intoapache:mainfrom
Closed
[GLUTEN-6705] [CORE] Refactor: Introduce GlutenCommitProtocol#6706baibaichen wants to merge 1 commit intoapache:mainfrom
baibaichen wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI |
1ec1963 to
5b32882
Compare
|
Run Gluten Clickhouse CI |
5b32882 to
f37fada
Compare
|
Run Gluten Clickhouse CI |
Contributor
|
thank you @baibaichen , can we make a copy for CH backend ? I think it's unnecessary to have to make abstract for diffferent backends... it just makes things complex. I'd like a stable code base. For |
Contributor
Author
|
Re-implment in #6761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #6705)
In ClickHouse Backend, we are preparing to support native delta write in Spark 3.5 and delta 3.2. This PR refactor codes to support
DelayedCommitProtocolinColumnarWriteFilesRDD. The Basic idea is introducingGlutenCommitProtocol,The main difference between
DelayedCommitProtocolandHadoopMapReduceCommitProtocolare how to setup and commit task. and henceSparkWriteFilesCommitProtocolis the direct implentation ofGlutenCommitProtocolforjobIdandtaskAttemptContext.Here are class hierarchy:
SparkHadoopMapReduceCommitProtocolis response for implmenting setup up taskVeloxBackendWriteandClickhouseBackendWriteis response for convertColumnBatchtoWriteTaskResultHow was this patch tested?
Using Existed UTs