Skip to content

[VL] Daily Update Velox Version (2024-02-01)#4604

Merged
JkSelf merged 1 commit intoapache:mainfrom
JkSelf:02_01
Feb 2, 2024
Merged

[VL] Daily Update Velox Version (2024-02-01)#4604
JkSelf merged 1 commit intoapache:mainfrom
JkSelf:02_01

Conversation

@JkSelf
Copy link
Copy Markdown
Contributor

@JkSelf JkSelf commented Feb 1, 2024

What changes were proposed in this pull request?

92f380b4d  Eliminate redundant Expr::addNulls calls (#8616)
09d07d3e7  Fix doc-gen-job so that it has 3 retries before failing. (#7706)
f4c326d7e  Add flag for registering Presto compatible signatures for Bitwise_*_agg functions (#8491)
eb6b585bb  Cleanup circleci script (#8618)
37ba7cb4c  Break up AllTypes.nonSortedSpillFunctions test (#8621)
d66b18f1d  Change cast(double as json) to pad 0 and use scientific notation (#8498)
a94509425  Make DuckDbQueryRunner.createTable flush once after all rows are written instead of after every row (#8611)
3beff35f3  Optimize copying primitive type vectors (#8617)
fbbeb5664  PyVelox implementation for Array Vector (#6100)
280fc8611  Add fmt::format_as for SpillStats and MemoryArbitrator::Stats (#8608)
a65afdb43  Make LocalExchangeSource.stop_ atomic (#8609)

How was this patch tested?

Existing unit tests.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@JkSelf JkSelf changed the title Velox rebase to 02_01 [VL] Daily Update Velox Version (2024-02-01) Feb 1, 2024
@JkSelf JkSelf force-pushed the 02_01 branch 2 times, most recently from bef6ef1 to b8b6506 Compare February 1, 2024 04:22
@JkSelf
Copy link
Copy Markdown
Contributor Author

JkSelf commented Feb 1, 2024

/Benchmark Velox

@JkSelf
Copy link
Copy Markdown
Contributor Author

JkSelf commented Feb 1, 2024

/Benchmark Velox

@GlutenPerfBot
Copy link
Copy Markdown
Contributor

GlutenPerfBot commented Feb 1, 2024

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4604_time.csv log/native_master_01_31_2024_f1ed68005_time.csv difference percentage
q1 34.80 32.75 -2.044 94.13%
q2 24.27 24.25 -0.027 99.89%
q3 38.40 37.43 -0.968 97.48%
q4 35.94 37.40 1.461 104.07%
q5 70.31 70.15 -0.154 99.78%
q6 7.11 7.00 -0.116 98.38%
q7 83.69 83.66 -0.026 99.97%
q8 87.09 85.87 -1.219 98.60%
q9 123.00 124.41 1.411 101.15%
q10 41.71 43.68 1.964 104.71%
q11 20.22 20.32 0.096 100.48%
q12 29.79 26.52 -3.270 89.02%
q13 45.62 45.62 -0.002 100.00%
q14 18.13 19.16 1.026 105.66%
q15 28.50 28.85 0.348 101.22%
q16 14.37 14.00 -0.368 97.44%
q17 100.99 102.02 1.030 101.02%
q18 149.19 149.84 0.644 100.43%
q19 13.36 12.62 -0.743 94.44%
q20 26.53 26.35 -0.183 99.31%
q21 221.44 228.32 6.883 103.11%
q22 13.43 13.50 0.075 100.56%
total 1227.90 1233.72 5.821 100.47%

@JkSelf JkSelf requested a review from rui-mo February 1, 2024 08:41
@JkSelf JkSelf merged commit 43093af into apache:main Feb 2, 2024
@GlutenPerfBot
Copy link
Copy Markdown
Contributor

GlutenPerfBot commented Feb 2, 2024

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4604_time.csv log/native_master_01_31_2024_f1ed68005_time.csv difference percentage
q1 34.76 32.75 -2.005 94.23%
q2 24.30 24.25 -0.049 99.80%
q3 38.85 37.43 -1.416 96.35%
q4 37.11 37.40 0.289 100.78%
q5 71.11 70.15 -0.961 98.65%
q6 6.53 7.00 0.464 107.10%
q7 83.63 83.66 0.039 100.05%
q8 86.14 85.87 -0.265 99.69%
q9 125.25 124.41 -0.839 99.33%
q10 43.99 43.68 -0.312 99.29%
q11 19.94 20.32 0.376 101.89%
q12 28.66 26.52 -2.143 92.52%
q13 45.77 45.62 -0.153 99.67%
q14 16.65 19.16 2.506 115.05%
q15 27.00 28.85 1.848 106.84%
q16 12.72 14.00 1.275 110.02%
q17 100.74 102.02 1.275 101.27%
q18 148.15 149.84 1.688 101.14%
q19 13.34 12.62 -0.726 94.56%
q20 26.49 26.35 -0.140 99.47%
q21 221.43 228.32 6.896 103.11%
q22 14.48 13.50 -0.983 93.21%
total 1227.06 1233.72 6.663 100.54%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rui-mo rui-mo rui-mo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JkSelf @GlutenPerfBot @rui-mo