[GLUTEN-3143][CH] Transform arrayJoin function to array join step to apply max_block_size#3191
Merged
liuneng1994 merged 1 commit intoapache:mainfrom Sep 20, 2023
Merged
Conversation
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
3 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
taiyang-li
force-pushed
the
gluten_3143
branch
from
e39c854 to
82db377
Compare
|
Run Gluten Clickhouse CI |
taiyang-li
force-pushed
the
gluten_3143
branch
from
7439ab9 to
06ecee1
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
taiyang-li
force-pushed
the
gluten_3143
branch
2 times, most recently
from
024e54a to
71c26f9
Compare
Contributor
Author
|
@liuneng1994 @baibaichen There has been serveral uts about lateral view explode/posexplode, so this pr didn't add new uts. |
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Notice that arrayJoin function and array join step are executing in different places. The former is in
ExpressionActions::execute, and latter is inArrayJoinAction::execute.max_block_sizeis currently only valid in array join step, so we must transform arrayJoin function to array join step to apply max_block_size.Notice: This pr relies on ClickHouse/ClickHouse#54664, but it can be merge firstly.
(Fixes: #3143)