Skip to content

[VL] Remove force cleanup in build_velox.sh #8609

@marin-ma

Description

@marin-ma

Backend

VL (Velox)

Bug description

https://github.com/apache/incubator-gluten/blob/291ff35722430ebcab98f957a3daa0b787d111d6/ep/build-velox/src/build_velox.sh#L184-L185

  • It may accidentally delete any uncommitted modifications in velox_ep
  • It will cause the build on MacOS to be failed by default. The build on MacOS doesn't install the thirdparty libraries like boost, re2 into the system folder such as /usr, instead, it installs the dependencies into the deps-install folder under velox repo when INSTALL_PREFIX env var is not set. The command will delete this folder and the following compile process will fail, reporting many of the libraries are missing.

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions