[mysql][hotfix] serialize isSuspended flag for MySqlBinlogSplit #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2022 16:53
serialize `isSuspended` field, and modify the test case to enable Snapshot failover. Signed-off-by: 元组 <[email protected]>
Signed-off-by: 元组 <[email protected]>
leonardBang
reviewed
Apr 6, 2022
| this.sourceConfig = sourceConfig; | ||
| this.splitAssigner = splitAssigner; | ||
| this.readersAwaitingSplit = new TreeSet<>(); | ||
| if (splitAssigner.getAssignerStatus() == NEWLY_ADDED_ASSIGNING |
Contributor
There was a problem hiding this comment.
We can use AssignerStatus.isAssigning(splitAssigner) || AssignerStatus.isAssigningFinished(splitAssigner) to cover newly assigning and initial assigning.
Signed-off-by: 元组 <[email protected]>
leonardBang
approved these changes
Apr 7, 2022
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @zhjwpku for the update, LGTM
Contributor
|
@zhjwpku Could you also open a PR for release-2.2 branch? |
Contributor
Author
|
yeah, see #1055 |
2 tasks
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 元组 [email protected]