[cdc-connector][Postgres][hotfix] Fix postgresSQL database connection leak #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@leonardBang , @ruanhang1993 , CC |
leonardBang
reviewed
Jan 19, 2024
Comment on lines
305
to
308
| public void close() { | ||
| public void close() throws Exception { | ||
| jdbcConnection.close(); | ||
| if (replicationConnection != null) { |
Contributor
There was a problem hiding this comment.
check null for jdbcConnection as well ?
loserwang1024
force-pushed
the
fix-leap-map
branch
from
faf4508 to
83d3365
Compare
leonardBang
approved these changes
Jan 24, 2024
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @loserwang1024 for the update, LGTM
joyCurry30
pushed a commit
to joyCurry30/flink-cdc-connectors
that referenced
this pull request
Mar 22, 2024
…on leak (apache#3013) This closes apache#2980.
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…on leak (apache#3013) This closes apache#2980.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2980. Now that PostgresSourceFetchTaskContext can only be contained by single thread now, it is no need to put into AtomicReference.