[cdc-common][cdc-pipelines][cdc-runtime] Use name instead of column in DropColumnEvent/AddColumnEvent. #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyCurry30
force-pushed
the
use_column_name
branch
from
d16c153 to
159307b
Compare
lvyanquan
reviewed
Dec 19, 2023
flink-cdc-common/src/main/java/com/ververica/cdc/common/event/AddColumnEvent.java
Show resolved
Hide resolved
Contributor
|
Thanks for this contribution, over all look good to me, left one comment. And can you fix the code style error? |
joyCurry30
force-pushed
the
use_column_name
branch
from
159307b to
7cba483
Compare
lvyanquan
approved these changes
Dec 19, 2023
Contributor
lvyanquan
left a comment
lvyanquan
left a comment
There was a problem hiding this comment.
LGTM. And @ruanhang1993 PTAL.
Contributor
|
@leonardBang @Jiabao-Sun CC and can you help to merge it? The following pipeline connectors rely on this issue. |
leonardBang
reviewed
Dec 22, 2023
| private final @Nullable String existedColumnName; | ||
|
|
||
| /** In the default scenario, we add fields at the end of the column. */ | ||
| public ColumnWithPosition(Column addColumn) { |
Contributor
There was a problem hiding this comment.
This is a public API, could we avoid changing this method ?
Contributor
There was a problem hiding this comment.
It's a PublicEvolving API, we change this because column type is unnecessary for sink to apply this SchemaChange, and source now just pass an arbitrary column type to build it.
Contributor
ruanhang1993
left a comment
ruanhang1993
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I left some comments.
.../src/main/java/com/ververica/cdc/runtime/serializer/schema/ColumnWithPositionSerializer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/ververica/cdc/runtime/serializer/schema/ColumnWithPositionSerializer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/ververica/cdc/runtime/serializer/schema/ColumnWithPositionSerializer.java
Show resolved
Hide resolved
joyCurry30
force-pushed
the
use_column_name
branch
from
1e0090a to
9921e8f
Compare
joyCurry30
force-pushed
the
use_column_name
branch
from
9921e8f to
7aef3a6
Compare
Contributor
Author
|
cc plz. @lvyanquan @ruanhang1993 |
…n DropColumnEvent/AddColumnEvent.
joyCurry30
force-pushed
the
use_column_name
branch
from
7aef3a6 to
d905a65
Compare
2 tasks
joyCurry30
added a commit
to joyCurry30/flink-cdc-connectors
that referenced
this pull request
Mar 22, 2024
…n DropColumnEvent/AddColumnEvent. (apache#2888)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…n DropColumnEvent/AddColumnEvent. (apache#2888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #2857.
Using the name of column, replace using column.
@lvyanquan