[postgres] Add commits of PostgresConnection back to distinguish with debezium's origin class #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@GOODBOY008 , @tigrulya-exe, CC |
… debezium's origin class
loserwang1024
force-pushed
the
add-comment
branch
from
78fefd7 to
a4de64a
Compare
joyCurry30
pushed a commit
to joyCurry30/flink-cdc-connectors
that referenced
this pull request
Mar 22, 2024
… debezium's origin class (apache#2839)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
… debezium's origin class (apache#2839)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2156, debezium version is bump to 1.9.7.Final, including PostgresConnection. It's a good thing, however some comments of PostgresConnection to distinguish with debezium's origin class are removed.
Two additional methods of our PostgresConnection is not included in 1.9.7.Final Debezium's PostgresConnection., so these comment should not be removed.
These comments are important for us for future to track the changes of Debezium's PostgresConnection. If these two PostgresConnection become same, we will remove it from cdc. Without it, it hard for us to distinguish the changes we did.