[docs] Fix overview docs to remove prefix of pipeline options. #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@PatrickRen , @ruanhang1993 , @lvyanquan , CC |
joyCurry30
reviewed
Dec 7, 2023
| pipeline: | ||
| name: mysql-to-kafka-pipeline | ||
| pipeline.global.parallelism: 1 | ||
| global.parallelism: 1 |
Contributor
There was a problem hiding this comment.
Just 'parallelism', not 'global.parallelism'
Contributor
Author
There was a problem hiding this comment.
@joyCurry30 , Thanks, I will remove it from cdc-pipeline.md and mysql's pipeline-test.yaml
Contributor
|
pipeline-test.yaml which under flink-cdc-pipeline-connector-mysql/src/test/resources has same problem. |
loserwang1024
force-pushed
the
fix-overview
branch
from
5f8c515 to
5d1a170
Compare
loserwang1024
force-pushed
the
fix-overview
branch
from
5d1a170 to
0e30fce
Compare
loserwang1024
changed the title
PatrickRen
approved these changes
Dec 7, 2023
Contributor
PatrickRen
left a comment
PatrickRen
left a comment
There was a problem hiding this comment.
@loserwang1024 Thanks for the patch! LGTM.
loserwang1024
force-pushed
the
fix-overview
branch
from
0e30fce to
4b9dceb
Compare
loserwang1024
added a commit
to loserwang1024/flink-cdc-connectors
that referenced
this pull request
Dec 7, 2023
loserwang1024
added a commit
to loserwang1024/flink-cdc-connectors
that referenced
this pull request
Dec 11, 2023
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2821, prefix of pipeline options is removed. Thus, prefix of pipeline options in overview docs also need to be removed