[pipeline-connector][starrocks] Fix char/varchar length inconsistency between cdc and starrocks #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… between cdc and starrocks
Contributor
|
The CI failure is not related to this pr, CC @PatrickRen. |
PatrickRen
approved these changes
Dec 6, 2023
Contributor
PatrickRen
left a comment
PatrickRen
left a comment
There was a problem hiding this comment.
@banmoy @lvyanquan Thanks for the contribution! LGTM
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
… between cdc and starrocks (apache#2829)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CDC framework, the length of char/varchar type represents the number of characters, but in StarRocks it represent the length of bytes. When mapping CDC char/varchar to that of StarRocks, we should multiply 3 for the length because a UTF-8 chinese character will use 3 bytes