Skip to content

Conversation

@PatrickRen
Copy link
Contributor

This pull request fixes keywords in route definitions, which should be "source-table" and "sink-table".

Please note that in RouteDef these two keywords are still "sourceTable" and "sinkTable", because they are Java object names. Only keywords in YAML need to be adjusted.

Copy link
Contributor

@loserwang1024 loserwang1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PatrickRen
Copy link
Contributor Author

Looks like the CI is linked to a wrong pull request.
This should be the real CI run: https://dev.azure.com/ververica/flink-cdc-connectors/_build/results?buildId=4379

Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatrickRen PatrickRen merged commit 6cb2ffe into apache:master Dec 6, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants