Skip to content

[oceanbase] Use global timestamp to start log client #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whhe merged 3 commits into from
Nov 28, 2023
Merged

[oceanbase] Use global timestamp to start log client #2565

whhe merged 3 commits into from
Nov 28, 2023

Conversation

@whhe
Copy link
Member

@whhe whhe commented Oct 19, 2023

This pr changed the startup order of snapshot and change events reading, and it will reduce the risk of change events buffer OOM.

@whhe whhe requested a review from ruanhang1993 October 20, 2023 06:17
leonardBang
leonardBang approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whhe for the contribution, LGTM, feel free to merge

@leonardBang leonardBang added this to the V3.0.0 milestone Nov 27, 2023
@whhe whhe merged commit 6e53733 into apache:master Nov 28, 2023
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Dec 2, 2023
@whhe @e-mhui
[oceanbase] Use global timestamp to start log client (apache#2565)
696cb83 
* use global timestamp to start log client

* remove redundant fields

* update log info
@xinwen-cs
Copy link

xinwen-cs commented Dec 13, 2023

In oceanbase-ce:3.1.4, SELECT TS_VALUE FROM oceanbase.V$OB_TIMESTAMP_SERVICE return microsecond rather than nanosecond

In oceanbase-ce:4.0.0.0, oceanbase.V$OB_TIMESTAMP_SERVICE or SYS.V$OB_TIMESTAMP_SERVICE does not exist

Is this code only test on enterprise edition?

@xinwen-cs
Copy link

xinwen-cs commented Dec 13, 2023

@whhe

@whhe
Copy link
Member Author

whhe commented Dec 13, 2023

In oceanbase-ce:3.1.4, SELECT TS_VALUE FROM oceanbase.V$OB_TIMESTAMP_SERVICE return microsecond rather than nanosecond

In oceanbase-ce:4.0.0.0, oceanbase.V$OB_TIMESTAMP_SERVICE or SYS.V$OB_TIMESTAMP_SERVICE does not exist

Is this code only test on enterprise edition?

Thanks for your reply. The target version is 4.2.1, and you are right that 3.x and 4.x use different precision in clock value. I will add a fallback process for it as soon as possible.

@whhe whhe mentioned this pull request Dec 13, 2023
Merged
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@whhe @ChaomingZhangCN
[oceanbase] Use global timestamp to start log client (apache#2565)
7e5f168 
* use global timestamp to start log client

* remove redundant fields

* update log info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardBang leonardBang leonardBang approved these changes

@ruanhang1993 ruanhang1993 Awaiting requested review from ruanhang1993

Assignees

@whhe whhe

Labels

None yet

Projects

None yet

Milestone

V3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@whhe @xinwen-cs @leonardBang