[mysql] Remove the finished snapshot splits for the binlog split when restoring from the checkpoint #2292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Jul 17, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @ruanhang1993 for the fix, I left some comments.
...ysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java
Outdated
Show resolved
Hide resolved
...ysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/split/MySqlBinlogSplit.java
Outdated
Show resolved
Hide resolved
...ql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReader.java
Outdated
Show resolved
Hide resolved
...mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/source/NewlyAddedTableITCase.java
Outdated
Show resolved
Hide resolved
...mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/source/NewlyAddedTableITCase.java
Outdated
Show resolved
Hide resolved
… restoring from the checkpoint
leonardBang
approved these changes
Jul 17, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @ruanhang1993 for the update, LGTM
leonardBang
reviewed
Jul 17, 2023
...ql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReader.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Jul 18, 2023
ruanhang1993
added a commit
to ruanhang1993/flink-cdc-connectors
that referenced
this pull request
Jul 19, 2023
… restoring from the checkpoint (apache#2292)
zhongqishang
pushed a commit
to zhongqishang/flink-cdc
that referenced
this pull request
Dec 7, 2023
… restoring from the checkpoint (apache#2292) (apache#2318)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
… restoring from the checkpoint (apache#2292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2282 .