Skip to content

[improve] update option names #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruanhang1993 merged 3 commits into from
Jun 29, 2023
Merged

[improve] update option names #2212

ruanhang1993 merged 3 commits into from
Jun 29, 2023

Conversation

@senlizishi
Copy link
Contributor

@senlizishi senlizishi commented Jun 14, 2023 •
edited
Loading

According to the following information

I think we need update option names as below:

  • database.whitelist -> database.include.list
  • schema.whitelist -> schema.include.list
  • table.whitelist -> table.include.list

@senlizishi
Copy link
Contributor Author

senlizishi commented Jun 14, 2023

@leonardBang @ruanhang1993 PTAL

@ruanhang1993
Copy link
Contributor

ruanhang1993 commented Jun 15, 2023

@senlizishi Thanks for contribution. It is reasonable. 2.4.0 version will not add new issue.
Let's put it in the next version.
Thanks~

@ruanhang1993 ruanhang1993 added this to the V2.4.1 milestone Jun 25, 2023
@ruanhang1993
Copy link
Contributor

ruanhang1993 commented Jun 25, 2023

@senlizishi Would you please rebase the branch master and make the CI pass? Thanks.

ruanhang1993
ruanhang1993 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanhang1993 ruanhang1993 removed this from the V2.4.1 milestone Jun 29, 2023
@ruanhang1993 ruanhang1993 merged commit ba5fcbc into apache:master Jun 29, 2023
@lvyanquan lvyanquan mentioned this pull request Sep 7, 2023
Closed
2 tasks
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
@senlizishi @GOODBOY008
[hotfix] update dbz option name 'xx. whitelist' to 'xx.include.list'(…
b7339d0 
…xx = database, schema or table) (apache#2212)

(cherry picked from commit ba5fcbc)
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
@senlizishi @GOODBOY008
[hotfix] update dbz option name 'xx. whitelist' to 'xx.include.list'(…
8352936 
…xx = database, schema or table) (apache#2212)

(cherry picked from commit ba5fcbc)
leonardBang pushed a commit that referenced this pull request Oct 31, 2023
@senlizishi @leonardBang
[hotfix] update dbz option name 'xx. whitelist' to 'xx.include.list'(…
409936e 
…xx = database, schema or table) (#2212)

(cherry picked from commit ba5fcbc)
zhongqishang pushed a commit to zhongqishang/flink-cdc that referenced this pull request Dec 7, 2023
@senlizishi @zhongqishang
[hotfix] update dbz option name 'xx. whitelist' to 'xx.include.list'(…
130c427 
…xx = database, schema or table) (apache#2212)

(cherry picked from commit ba5fcbc)
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@senlizishi @ChaomingZhangCN
[hotfix] update dbz option name 'xx. whitelist' to 'xx.include.list'(…
3372117 
…xx = database, schema or table) (apache#2212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruanhang1993 ruanhang1993 ruanhang1993 approved these changes

Assignees

@senlizishi senlizishi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@senlizishi @ruanhang1993