Skip to content

[cdc-base] Extract the common parts of each ScanFetchTask into an abstract class #2690

@loserwang1024

Description

@loserwang1024

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Recently, I want to add an ability to skip backfill , as mentioned in #2553. However, I found myself copying the same code to each ScanFetchTask class, even though they shared the same code. These ScanFetchTask classes have a common mechanism for watermark emit and backfill task. Therefore, it would be beneficial to extract these common parts into an abstract class called AbstractScanFetcherTask.

By doing so, we promote code reusability and improve maintainability in the long run. For example, we can easily add other common functionalities such as skip backfill ability and additional hooks for testing in AbstractScanFetcherTask.

Solution

No response

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions