Skip to content

Conversation

@AryanVBW
Copy link
Contributor

@AryanVBW AryanVBW commented Feb 10, 2025

Migrating external font dependencies to local resources and fixes font path resolution issues.

Changes Made

  • Downloaded and locally hosted fonts from fonts.gstatic.com & cdnjs.cloudflare.com
  • Fixed Material Icons font path resolution:
    Updated from /font/material-icons.ttf to ../font/material-icons.ttf

Testing

  • Verified all fonts load correctly with new local paths
  • Confirmed Material Icons display properly across all pages
    @jdailey @vorburger @meonkeys

Changed font path from /font/material-icons.ttf to ../font/material-icons.ttf
to properly resolve the Material Icons font from the CSS directory
- Download and host Fonts locally from fonts.gstatic.com & cdnjs.cloudflare.com locally
@meonkeys
Copy link
Contributor

Thank you @AryanVBW ! I'll merge this since I'm now able to do so.

I only skimmed the code changes. I'll review them line by line if something breaks. My acceptance criteria will be that https://fineract.apache.org still looks and works more or less the same, and that https://fineract.apache.org/docs/current/ no longer fails to fetch images and icons from 3rd party websites.

@meonkeys meonkeys merged commit f7513db into apache:asf-site May 28, 2025
@meonkeys
Copy link
Contributor

Looks like we're getting some 404s for some files matching fontawesome-webfont.*. @AryanVBW will you open a new PR to fix that? repro: open browser dev console to network tab and hard-reload https://fineract.apache.org/docs/current/

@meonkeys meonkeys changed the title 🔒Migrate External Fonts to Local Resources & Fix Font Paths Migrate External Fonts to Local Resources & Fix Font Paths May 28, 2025
@meonkeys
Copy link
Contributor

never mind, I was able to fix them with 4517783

@AryanVBW
Copy link
Contributor Author

Oh, you fixed it! That’s awesome to hear. I’d be happy to help you with anything you need. If there’s any work I can contribute to, I’d definitely love to support the open source community

@AryanVBW
Copy link
Contributor Author

AryanVBW commented May 31, 2025

never mind, I was able to fix them with 4517783

I'm deeply grateful to you for sharing this with me and for giving value to others contributer thank you from the bottom of my heart.
Really love your nature @meonkeys

@meonkeys
Copy link
Contributor

@AryanVBW are you interested in working on the auto-deploy? See "automate deployment of generated versioned asciidoc" in the wish list in the top-level Readme.md.

Discussion at https://mifos.slack.com/archives/C028634A61L/p1755877617970599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants