Skip to content

Conversation

@Alonexc
Copy link
Contributor

@Alonexc Alonexc commented Apr 9, 2024

Fixes #97

Motivation

runtime tcp http grpc client impl

Modifications

runtime tcp http grpc client impl

Documentation

  • Does this pull request introduce a new feature? yes

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly refer to the standard title format used in other PRs.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 9, 2024

@Lambert-Rao

Do you have any question on the implementation of Operation classes?

@Alonexc Alonexc changed the title runtime tcp http grpc client impl [ISSUE #97] Runtime tcp http grpc client impl Apr 10, 2024
@Alonexc
Copy link
Contributor Author

Alonexc commented Apr 10, 2024

This pr has grpc version conflicts.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 10, 2024

This pr has grpc version conflicts.

Can it be fixed? Is some major modification required?

@Alonexc
Copy link
Contributor Author

Alonexc commented Apr 10, 2024

This pr has grpc version conflicts.

Can it be fixed? Is some major modification required?

I'll try to fix it, but I'm not sure if it can be done because the grpc version between eventmesh-sdk and jetcd is not compatible, I've looked at the various versions of jetcd for the grpc version, and it's not the same as the eventmesh-sdk grpc version, and I'm not sure if upgrading the grp version will make both sides compatible, I'll try to do it that way, otherwise I think we should prioritise securing the runtime client implementation.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 10, 2024

We may discard etcd implementation by now since nacos is the recommended one.

@Lambert-Rao
Copy link
Contributor

@Lambert-Rao

Do you have any question on the implementation of Operation classes?

No, they look good to me

@Lambert-Rao
Copy link
Contributor

@Alonexc It seems that test is blocked because Github Action doesn't have working enviroment.
Please try to exclude these tests, add time limit and use try-catch to avoide the problem.

@Alonexc
Copy link
Contributor Author

Alonexc commented Apr 10, 2024

@Alonexc It seems that test is blocked because Github Action doesn't have working enviroment. Please try to exclude these tests, add time limit and use try-catch to avoide the problem.

Do you mean adding paths-ignore paths in ci?

@Alonexc
Copy link
Contributor Author

Alonexc commented Apr 10, 2024

Added etcd connecttime , but it didn't build successfully, I commented out the test code for etcd and will follow up to fix the problem, local testing of the client test for etcd is fine.

@Lambert-Rao
Copy link
Contributor

@Alonexc It seems that test is blocked because Github Action doesn't have working enviroment. Please try to exclude these tests, add time limit and use try-catch to avoide the problem.

Do you mean adding paths-ignore paths in ci?

yes

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia merged commit 13d3728 into apache:main Apr 15, 2024
@Pil0tXia
Copy link
Member

@Alonexc It seems Runtime's grpc version is too old. You can't even download its source code in IDEA. ForwardingChannelBuilder and StreamObservers are deprecated in 1.60.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Runtime TCP,HTTP,GRPC client impl

3 participants