Skip to content

[ISSUE #859] Add unit tests for EventMesh SDK for Java #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qqeasonchen merged 4 commits into from
Jun 1, 2022
Merged

[ISSUE #859] Add unit tests for EventMesh SDK for Java #894

qqeasonchen merged 4 commits into from
Jun 1, 2022

Conversation

@wallezhang
Copy link
Contributor

@wallezhang wallezhang commented May 26, 2022 •
edited by xiaoyang-sde
Loading

Fixes ISSUE #859.

Motivation

Add missing unit tests

Modifications

Add unit tests for eventmesh-sdk-java module.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

github-actions[bot]
github-actions bot reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Group：
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

@codecov
Copy link

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #894 (0a908c7) into master (4746d73) will increase coverage by 1.48%.
The diff coverage is n/a.

❗ Current head 0a908c7 differs from pull request most recent head cff8d27. Consider uploading reports for the commit cff8d27 to get more accurate results

@@             Coverage Diff             @@
##             master    #894      +/-   ##
===========================================
+ Coverage      7.13%   8.62%   +1.48%     
- Complexity      446     509      +63     
===========================================
  Files           346     346              
  Lines         21695   21695              
  Branches       2415    2415              
===========================================
+ Hits           1548    1871     +323     
+ Misses        20029   19682     -347     
- Partials        118     142      +24
Impacted Files Coverage Δ
...sh/client/grpc/consumer/EventMeshGrpcConsumer.java 75.80% <ø> (+75.80%) ⬆️
...sh/client/grpc/producer/EventMeshGrpcProducer.java 68.88% <ø> (+68.88%) ⬆️
...tandalone/broker/task/HistoryMessageClearTask.java 29.41% <0.00%> (-17.65%) ⬇️
...mesh/connector/standalone/broker/MessageQueue.java 32.46% <0.00%> (-7.80%) ⬇️
.../client/grpc/config/EventMeshGrpcClientConfig.java 38.46% <0.00%> (+38.46%) ⬆️
...entmesh/client/grpc/consumer/SubStreamHandler.java 54.66% <0.00%> (+54.66%) ⬆️
...tmesh/client/grpc/producer/CloudEventProducer.java 65.51% <0.00%> (+65.51%) ⬆️
...e/eventmesh/client/tcp/common/EventMeshCommon.java 87.50% <0.00%> (+87.50%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4746d73...cff8d27. Read the comment docs.

@xiaoyang-sde xiaoyang-sde changed the title [ISSUE #859]Add unit tests for sdk java [ISSUE #859] Add unit tests for EventMesh SDK for Java May 26, 2022
@xiaoyang-sde xiaoyang-sde requested a review from ruanwenjun May 26, 2022 21:11
@qqeasonchen
Copy link
Contributor

qqeasonchen commented May 31, 2022

@wallezhang please fix the conflicts.

@wallezhang
Copy link
Contributor Author

wallezhang commented May 31, 2022

@wallezhang please fix the conflicts.

Done.

qqeasonchen
qqeasonchen approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen
Copy link
Contributor

qqeasonchen commented Jun 1, 2022

@ruanwenjun please check if the change you requested is resoved, then can merge it.

ruanwenjun
ruanwenjun approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen qqeasonchen merged commit feef847 into apache:master Jun 1, 2022
@wallezhang wallezhang deleted the add-unit-test-for-sdk-java branch June 1, 2022 08:35
@ruanwenjun ruanwenjun modified the milestones: 1.4.0, 1.5.0 Jun 25, 2022
xwm1992 pushed a commit that referenced this pull request Aug 4, 2022
@qqeasonchen
Merge pull request #894 from wallezhang/add-unit-test-for-sdk-java
13e9f2f 
[ISSUE #859] Add unit tests for EventMesh SDK for Java
@Pil0tXia Pil0tXia mentioned this pull request Jan 9, 2024
Open
2 tasks
@dependabot dependabot bot mentioned this pull request Jun 3, 2024
Merged
@dependabot dependabot bot mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@qqeasonchen qqeasonchen qqeasonchen approved these changes

Assignees

@wallezhang wallezhang

Labels

testing

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wallezhang @qqeasonchen @ruanwenjun @xiaoyang-sde