Skip to content

[ISSUE #456] Remove license name, add LICENSE file #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 5 commits into from
Dec 10, 2021
Merged

[ISSUE #456] Remove license name, add LICENSE file #535

xwm1992 merged 5 commits into from
Dec 10, 2021

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Sep 24, 2021

related issue #456

  1. remove license name in allowed-licenses.txt
  2. use LICENSE to announce the license

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch 4 times, most recently from 8d87d4b to 2586de2 Compare September 24, 2021 05:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #535 (b7d5282) into develop (8b6c827) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #535      +/-   ##
=============================================
- Coverage      11.20%   11.13%   -0.08%     
+ Complexity       389      385       -4     
=============================================
  Files            261      261              
  Lines          12296    12296              
  Branches        1044     1044              
=============================================
- Hits            1378     1369       -9     
- Misses         10800    10810      +10     
+ Partials         118      117       -1
Impacted Files Coverage Δ
...ol/tcp/client/group/ClientSessionGroupMapping.java 0.00% <0.00%> (ø)
...tandalone/broker/task/HistoryMessageClearTask.java 33.33% <0.00%> (-16.67%) ⬇️
...mesh/connector/standalone/broker/MessageQueue.java 32.46% <0.00%> (-7.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6c827...b7d5282. Read the comment docs.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch from 2586de2 to caa0b5d Compare September 24, 2021 07:12
jonyangx
jonyangx reviewed Sep 26, 2021
View reviewed changes
Copy link
Contributor

@jonyangx jonyangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

========================================================================
LGPL licenses

The following components are provided under the LGPL License. See project link for details.
The text of each license is also included at licenses/LICENSE-[project].txt.

hibernate-commons-annotations 5.1.2.Final: https://mvnrepository.com/artifact/org.hibernate.common/hibernate-commons-annotations/5.1.2.Final, LGPL 2.1
hibernate-core 5.4.32.Final: https://mvnrepository.com/artifact/org.hibernate/hibernate-core/5.4.32.Final, LGPL 2.1

refer to: https://www.apache.org/legal/resolved.html
LICENSE file must not include LGPL2.1 license .

@ruanwenjun
Copy link
Member Author

ruanwenjun commented Sep 26, 2021

@jonyangx Thanks for your reminder, this is a big mistake. I have removed these licenses, since these are not in binary jar. And now the LICENSE only contains binary dependency.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch from 83f3673 to 5cc34cd Compare September 26, 2021 15:17
@ruanwenjun ruanwenjun requested a review from jonyangx September 26, 2021 17:23
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch from 5cc34cd to b7d5282 Compare October 5, 2021 03:13
xwm1992
xwm1992 reviewed Oct 8, 2021
View reviewed changes
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch from b7d5282 to 9eb890a Compare October 8, 2021 14:11
@ruanwenjun
Copy link
Member Author

ruanwenjun commented Oct 8, 2021

@xwm1992 I think we may still need to use a shell script to check the license, rather than use gradle license check plugin. Because the gradle plugin check result doesn't correct, some of them are not appeared in the binary file.

@ruanwenjun ruanwenjun marked this pull request as draft November 10, 2021 02:57
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch from 9eb890a to 5953da1 Compare November 29, 2021 11:40
@ruanwenjun ruanwenjun marked this pull request as ready for review November 29, 2021 11:41
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch 2 times, most recently from 0308154 to 7adff47 Compare November 29, 2021 11:43
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixLicenseCheck branch from 7adff47 to 05ac1fe Compare December 10, 2021 01:24
@ruanwenjun ruanwenjun mentioned this pull request Dec 10, 2021
Merged
@ruanwenjun ruanwenjun requested a review from xwm1992 December 10, 2021 01:25
@ruanwenjun
Copy link
Member Author

ruanwenjun commented Dec 10, 2021

This pr is ready to review now.

xwm1992
xwm1992 approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonyangx jonyangx requested review from jonyangx and xwm1992 December 10, 2021 02:55
@xwm1992 xwm1992 merged commit fafd741 into apache:develop Dec 10, 2021
xwm1992 added a commit that referenced this pull request Aug 4, 2022
@xwm1992
Merge pull request #535 from ruanwenjun/dev_wenjun_fixLicenseCheck
0910681 
[ISSUE #456] Remove license name, add LICENSE file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonyangx jonyangx jonyangx approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ruanwenjun @codecov-commenter @jonyangx @xwm1992