Skip to content

Conversation

@cnzakii
Copy link
Member

@cnzakii cnzakii commented Aug 14, 2024

Fixes #5077

Motivation

A SendMessageCallback field has been added to ConnectRecord, allowing the result of data transmission to be handled through the callback.onSuccess and callback.onException methods. The HttpSinkConnector needs to support this functionality, so it requires modification.

Modifications

Adapt and modify the HttpSinkConnector and optimize some code logic.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@cnzakii
Copy link
Member Author

cnzakii commented Aug 14, 2024

@xwm1992 PTAL

Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 8cb8df5 into apache:master Aug 16, 2024
@cnzakii cnzakii deleted the http-sink branch August 16, 2024 10:33
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 19, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…che#5078)

* feat: Support CallBack for ConnectRecord

* doc: Improve some documentation

* feat: Support for multi-server data callbacks

* perf: Optimize some logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] HTTP Sink Connector supports result callback

3 participants