Skip to content

[ISSUE #5042] Exclude mysql-connector-j from classpath #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xwm1992 merged 2 commits into from
Jul 26, 2024
Merged

[ISSUE #5042] Exclude mysql-connector-j from classpath #5043

xwm1992 merged 2 commits into from
Jul 26, 2024

Conversation

@Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Jul 23, 2024

Fixes #5042

Motivation

Please see #5038 (comment)

Modifications

Add a new deniedLicense and change implementation namespace to compileOnly.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia Pil0tXia mentioned this pull request Jul 23, 2024
Merged
@codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.27%. Comparing base (70f9892) to head (4842da3).
Report is 122 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5043      +/-   ##
============================================
- Coverage     15.91%   15.27%   -0.64%     
+ Complexity     1734     1506     -228     
============================================
  Files           897      879      -18     
  Lines         31982    32168     +186     
  Branches       2737     2916     +179     
============================================
- Hits           5089     4915     -174     
- Misses        26413    26723     +310     
- Partials        480      530      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xwm1992
xwm1992 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

harshithasudhakar
harshithasudhakar approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@harshithasudhakar harshithasudhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit b3a42e1 into apache:master Jul 26, 2024
@Pil0tXia Pil0tXia deleted the pil0txia/enhance_5042 branch December 31, 2024 11:45
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@Pil0tXia
[ISSUE apache#5042] Exclude mysql-connector-j from classpath (apach…
9be3018 
…e#5043)

* feat: Add a new deniedLicense

* feat: change implementation namespace to compileOnly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwm1992 xwm1992 xwm1992 approved these changes

@harshithasudhakar harshithasudhakar harshithasudhakar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Exclude mysql-connector-j from classpath

3 participants

@Pil0tXia @xwm1992 @harshithasudhakar